Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1716283002: Fix x/y position of gesture scroll events. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_regression
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix x/y position of gesture scroll events. The gesture scroll events did not have the x/y position assigned to them. Add unit test to assert this is true. BUG=568183 Committed: https://crrev.com/7b62326053982db1043e94d94ac7c2975727bd60 Cr-Commit-Position: refs/heads/master@{#377055}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add globalX/globalY tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -15 lines) Patch
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 4 chunks +17 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 9 chunks +34 lines, -9 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
dtapuska
4 years, 10 months ago (2016-02-22 19:43:23 UTC) #3
tdresser
LGTM with nit. https://codereview.chromium.org/1716283002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc File content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc (right): https://codereview.chromium.org/1716283002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc#newcode151 content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc:151: EXPECT_EQ(12, sent_gesture_events()[0].y); Let's check globalX/globalY somewhere ...
4 years, 10 months ago (2016-02-22 19:58:48 UTC) #4
dtapuska
https://codereview.chromium.org/1716283002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc File content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc (right): https://codereview.chromium.org/1716283002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc#newcode151 content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc:151: EXPECT_EQ(12, sent_gesture_events()[0].y); On 2016/02/22 19:58:48, tdresser wrote: > Let's ...
4 years, 10 months ago (2016-02-22 20:28:46 UTC) #5
tdresser
LGTM, thanks!
4 years, 10 months ago (2016-02-22 20:35:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716283002/20001
4 years, 10 months ago (2016-02-23 16:24:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/178070)
4 years, 10 months ago (2016-02-23 18:12:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716283002/20001
4 years, 10 months ago (2016-02-23 18:46:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 19:30:23 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:32:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b62326053982db1043e94d94ac7c2975727bd60
Cr-Commit-Position: refs/heads/master@{#377055}

Powered by Google App Engine
This is Rietveld 408576698