Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1723513002: Revert of Enable gesture events for wheel events on all platforms other that OSX. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
skobes, tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam, ymalik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners_4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable gesture events for wheel events on all platforms other that OSX. (patchset #1 id:1 of https://codereview.chromium.org/1716493002/ ) Reason for revert: iframes were broken; will re-land once fixed Original issue's description: > Enable gesture events for wheel events on all platforms other that OSX. > > OSX has some remaining bugs to deal with overscroll for gesture events > but enable it everywhere else. > > BUG=568183 > > Committed: https://crrev.com/e552e8a9e51777b6579bbfaa0be8ceb58a57b70a > Cr-Commit-Position: refs/heads/master@{#376604} TBR=skobes@chromium.org,tdresser@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=568183 Committed: https://crrev.com/d4df77d762e1251871e78b275c9de89bce995513 Cr-Commit-Position: refs/heads/master@{#376734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/common/input/input_event_utils.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
dtapuska
Created Revert of Enable gesture events for wheel events on all platforms other that OSX.
4 years, 10 months ago (2016-02-22 14:31:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723513002/1
4 years, 10 months ago (2016-02-22 14:34:40 UTC) #2
tdresser
LGTM - make sure to get a good test in place for this case when ...
4 years, 10 months ago (2016-02-22 14:35:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723513002/1
4 years, 10 months ago (2016-02-22 15:04:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723513002/1
4 years, 10 months ago (2016-02-22 15:33:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 15:47:46 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 15:49:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4df77d762e1251871e78b275c9de89bce995513
Cr-Commit-Position: refs/heads/master@{#376734}

Powered by Google App Engine
This is Rietveld 408576698