chrome/browser/password_manager/save_password_infobar_delegate.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_proxy_mac_unittest.cc ('k') | chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/save_password_infobar_delegate.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc

index dfb8dc0c8b45e0489130f527f4872d9f45f90558..8372e1486eb567a5e50db489f98a545659fd7c99 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc

@@ -20,6 +20,7 @@

#include "content/public/browser/web_contents.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

+#include "url/origin.h"

// static

void SavePasswordInfoBarDelegate::Create(

@@ -95,9 +96,9 @@ SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(

base::string16 message;

gfx::Range message_link_range = gfx::Range();

PasswordTittleType type =

- form_to_save_->pending_credentials().federation_url.is_empty()

- ? PasswordTittleType::SAVE_PASSWORD

- : PasswordTittleType::SAVE_ACCOUNT;

+ form_to_save_->pending_credentials().federation_origin.unique()

+ ? PasswordTittleType::SAVE_PASSWORD

+ : PasswordTittleType::UPDATE_PASSWORD;

melandory 2016/03/11 10:01:07 Sad story about the fix which didn't survive https

GetSavePasswordDialogTitleTextAndLinkRange(

web_contents->GetVisibleURL(), form_to_save_->observed_form().origin,

is_smartlock_branding_enabled, type,