CREDENTIAL: Convert federations from URLs to origins throughout.

chrome/browser/password_manager/save_password_infobar_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
 
 #include <utility>
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/browser_sync/browser/profile_sync_service.h"
 #include "components/infobars/core/infobar.h"
 #include "components/password_manager/core/browser/password_bubble_experiment.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "url/origin.h"
 
 // static
 void SavePasswordInfoBarDelegate::Create(
     content::WebContents* web_contents,
     scoped_ptr<password_manager::PasswordFormManager> form_to_save,
     const std::string& uma_histogram_suffix) {
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   sync_driver::SyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile);
@@ skipping 55 matching lines @@
       should_show_first_run_experience_(should_show_first_run_experience),
       web_contents_(web_contents) {
   if (!uma_histogram_suffix_.empty()) {
     password_manager::metrics_util::LogUMAHistogramBoolean(
         "PasswordManager.SavePasswordPromptDisplayed_" + uma_histogram_suffix_,
         true);
   }
   base::string16 message;
   gfx::Range message_link_range = gfx::Range();
   PasswordTittleType type =
-      form_to_save_->pending_credentials().federation_url.is_empty()
-      ? PasswordTittleType::SAVE_PASSWORD
-      : PasswordTittleType::SAVE_ACCOUNT;
+      form_to_save_->pending_credentials().federation_origin.unique()
+          ? PasswordTittleType::SAVE_PASSWORD
+          : PasswordTittleType::UPDATE_PASSWORD;

[melandory, 2016/03/11 10:01:07]

Sad story about the fix which didn't survive
https://codereview.chromium.org/1717263002/ :)

   GetSavePasswordDialogTitleTextAndLinkRange(
       web_contents->GetVisibleURL(), form_to_save_->observed_form().origin,
       is_smartlock_branding_enabled, type,
       &message, &message_link_range);
   SetMessage(message);
   SetMessageLinkRange(message_link_range);
 }
 
 base::string16 SavePasswordInfoBarDelegate::GetFirstRunExperienceMessage() {
   return should_show_first_run_experience_
@@ skipping 25 matching lines @@
   infobar_response_ = password_manager::metrics_util::REMEMBER_PASSWORD;
   return true;
 }
 
 bool SavePasswordInfoBarDelegate::Cancel() {
   DCHECK(form_to_save_.get());
   form_to_save_->PermanentlyBlacklist();
   infobar_response_ = password_manager::metrics_util::NEVER_REMEMBER_PASSWORD;
   return true;
 }