chrome/browser/password_manager/password_store_proxy_mac_unittest.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | chrome/browser/password_manager/save_password_infobar_delegate.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

index 2ea0d468e7361c2d72713e4691269062d59cdb69..1a8f769759582e5324eee3b6558abd81b39b62a6 100644

--- a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

+++ b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

@@ -25,6 +25,7 @@

#include "crypto/mock_apple_keychain.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "url/origin.h"

namespace {

@@ -224,7 +225,8 @@ void PasswordStoreProxyMacTest::CheckRemoveLoginsBetween(bool check_created) {

old_form.origin = GURL("http://accounts.google.com/LoginAuth");

old_form.signon_realm = "http://accounts.google.com/";

old_form.username_value = base::ASCIIToUTF16("my_username");

- old_form.federation_url = GURL("http://accounts.google.com/federation");

+ old_form.federation_origin =

+ url::Origin(GURL("http://accounts.google.com/federation"));

PasswordForm new_form = old_form;

new_form.origin = GURL("http://accounts.google2.com/LoginAuth");