chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « chrome/browser/password_manager/save_password_infobar_delegate.cc ('k') | chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

index ad27954feec1ab6a3b7dd430f920739a7ed4cfe8..c8ef42ecaa8931082494f29ee73acc29f830061f 100644

--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

@@ -21,7 +21,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/gtest_mac.h"

#include "url/gurl.h"

+#include "url/origin.h"

@interface AccountAvatarFetcherTestManager : AccountAvatarFetcherManager {

std::vector<GURL> fetchedAvatars_;

@@ -159,7 +159,7 @@ TEST_F(AccountChooserViewControllerTest, ConfiguresFederatedCredential) {

const char name[] = "Peter the Great";

PasswordDialogController::FormsVector local_forms;

local_forms.push_back(Credential("pizza"));

- local_forms.back()->federation_url = GURL(federation);

+ local_forms.back()->federation_origin = url::Origin(GURL(federation));

local_forms.back()->display_name = base::ASCIIToUTF16(name);

SetUpAccountChooser(&local_forms);