chrome/browser/password_manager/native_backend_libsecret_unittest.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

index c26802d0ceb20cae1b0bdaad6d0b751eaa188346..a589863e4a9dd86579a4d59071cb0405d261dc31 100644

--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

@@ -292,7 +292,8 @@ class NativeBackendLibsecretTest : public testing::Test {

form_google_.date_synced = base::Time::Now();

form_google_.display_name = UTF8ToUTF16("Joe Schmoe");

form_google_.icon_url = GURL("http://www.google.com/icon");

- form_google_.federation_url = GURL("http://www.google.com/federation_url");

+ form_google_.federation_origin =

+ url::Origin(GURL("http://www.google.com/"));

form_google_.skip_zero_click = true;

form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT;

form_google_.form_data.name = UTF8ToUTF16("form_name");

@@ -309,7 +310,8 @@ class NativeBackendLibsecretTest : public testing::Test {

form_facebook_.date_synced = base::Time::Now();

form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");

form_facebook_.icon_url = GURL("http://www.facebook.com/icon");

- form_facebook_.federation_url = GURL("http://www.facebook.com/federation");

+ form_facebook_.federation_origin =

+ url::Origin(GURL("http://www.facebook.com/"));

form_facebook_.skip_zero_click = true;

form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT;

@@ -396,7 +398,8 @@ class NativeBackendLibsecretTest : public testing::Test {

base::Int64ToString(form.date_synced.ToInternalValue()));

CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));

CheckStringAttribute(item, "avatar_url", form.icon_url.spec());

- CheckStringAttribute(item, "federation_url", form.federation_url.spec());

+ CheckStringAttribute(item, "federation_url",

+ form.federation_origin.Serialize());

CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);

CheckUint32Attribute(item, "generation_upload_status",

form.generation_upload_status);