Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS2 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdarg.h> 5 #include <stdarg.h>
6 #include <stddef.h> 6 #include <stddef.h>
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 form_google_.username_value = UTF8ToUTF16("joeschmoe"); 285 form_google_.username_value = UTF8ToUTF16("joeschmoe");
286 form_google_.password_element = UTF8ToUTF16("pass"); 286 form_google_.password_element = UTF8ToUTF16("pass");
287 form_google_.password_value = UTF8ToUTF16("seekrit"); 287 form_google_.password_value = UTF8ToUTF16("seekrit");
288 form_google_.submit_element = UTF8ToUTF16("submit"); 288 form_google_.submit_element = UTF8ToUTF16("submit");
289 form_google_.signon_realm = "http://www.google.com/"; 289 form_google_.signon_realm = "http://www.google.com/";
290 form_google_.type = PasswordForm::TYPE_GENERATED; 290 form_google_.type = PasswordForm::TYPE_GENERATED;
291 form_google_.date_created = base::Time::Now(); 291 form_google_.date_created = base::Time::Now();
292 form_google_.date_synced = base::Time::Now(); 292 form_google_.date_synced = base::Time::Now();
293 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 293 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
294 form_google_.icon_url = GURL("http://www.google.com/icon"); 294 form_google_.icon_url = GURL("http://www.google.com/icon");
295 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 295 form_google_.federation_origin =
296 url::Origin(GURL("http://www.google.com/"));
296 form_google_.skip_zero_click = true; 297 form_google_.skip_zero_click = true;
297 form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT; 298 form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT;
298 form_google_.form_data.name = UTF8ToUTF16("form_name"); 299 form_google_.form_data.name = UTF8ToUTF16("form_name");
299 300
300 form_facebook_.origin = GURL("http://www.facebook.com/"); 301 form_facebook_.origin = GURL("http://www.facebook.com/");
301 form_facebook_.action = GURL("http://www.facebook.com/login"); 302 form_facebook_.action = GURL("http://www.facebook.com/login");
302 form_facebook_.username_element = UTF8ToUTF16("user"); 303 form_facebook_.username_element = UTF8ToUTF16("user");
303 form_facebook_.username_value = UTF8ToUTF16("a"); 304 form_facebook_.username_value = UTF8ToUTF16("a");
304 form_facebook_.password_element = UTF8ToUTF16("password"); 305 form_facebook_.password_element = UTF8ToUTF16("password");
305 form_facebook_.password_value = UTF8ToUTF16("b"); 306 form_facebook_.password_value = UTF8ToUTF16("b");
306 form_facebook_.submit_element = UTF8ToUTF16("submit"); 307 form_facebook_.submit_element = UTF8ToUTF16("submit");
307 form_facebook_.signon_realm = "http://www.facebook.com/"; 308 form_facebook_.signon_realm = "http://www.facebook.com/";
308 form_facebook_.date_created = base::Time::Now(); 309 form_facebook_.date_created = base::Time::Now();
309 form_facebook_.date_synced = base::Time::Now(); 310 form_facebook_.date_synced = base::Time::Now();
310 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe"); 311 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");
311 form_facebook_.icon_url = GURL("http://www.facebook.com/icon"); 312 form_facebook_.icon_url = GURL("http://www.facebook.com/icon");
312 form_facebook_.federation_url = GURL("http://www.facebook.com/federation"); 313 form_facebook_.federation_origin =
314 url::Origin(GURL("http://www.facebook.com/"));
313 form_facebook_.skip_zero_click = true; 315 form_facebook_.skip_zero_click = true;
314 form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT; 316 form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT;
315 317
316 form_isc_.origin = GURL("http://www.isc.org/"); 318 form_isc_.origin = GURL("http://www.isc.org/");
317 form_isc_.action = GURL("http://www.isc.org/auth"); 319 form_isc_.action = GURL("http://www.isc.org/auth");
318 form_isc_.username_element = UTF8ToUTF16("id"); 320 form_isc_.username_element = UTF8ToUTF16("id");
319 form_isc_.username_value = UTF8ToUTF16("janedoe"); 321 form_isc_.username_value = UTF8ToUTF16("janedoe");
320 form_isc_.password_element = UTF8ToUTF16("passwd"); 322 form_isc_.password_element = UTF8ToUTF16("passwd");
321 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 323 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
322 form_isc_.submit_element = UTF8ToUTF16("login"); 324 form_isc_.submit_element = UTF8ToUTF16("login");
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 // We don't check the date created. It varies. 391 // We don't check the date created. It varies.
390 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user); 392 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user);
391 CheckUint32Attribute(item, "type", form.type); 393 CheckUint32Attribute(item, "type", form.type);
392 CheckUint32Attribute(item, "times_used", form.times_used); 394 CheckUint32Attribute(item, "times_used", form.times_used);
393 CheckUint32Attribute(item, "scheme", form.scheme); 395 CheckUint32Attribute(item, "scheme", form.scheme);
394 CheckStringAttribute( 396 CheckStringAttribute(
395 item, "date_synced", 397 item, "date_synced",
396 base::Int64ToString(form.date_synced.ToInternalValue())); 398 base::Int64ToString(form.date_synced.ToInternalValue()));
397 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name)); 399 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));
398 CheckStringAttribute(item, "avatar_url", form.icon_url.spec()); 400 CheckStringAttribute(item, "avatar_url", form.icon_url.spec());
399 CheckStringAttribute(item, "federation_url", form.federation_url.spec()); 401 CheckStringAttribute(item, "federation_url",
402 form.federation_origin.Serialize());
400 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click); 403 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);
401 CheckUint32Attribute(item, "generation_upload_status", 404 CheckUint32Attribute(item, "generation_upload_status",
402 form.generation_upload_status); 405 form.generation_upload_status);
403 CheckStringAttribute(item, "application", app_string); 406 CheckStringAttribute(item, "application", app_string);
404 autofill::FormData actual; 407 autofill::FormData actual;
405 DeserializeFormDataFromBase64String( 408 DeserializeFormDataFromBase64String(
406 static_cast<char*>(g_hash_table_lookup(item->attributes, "form_data")), 409 static_cast<char*>(g_hash_table_lookup(item->attributes, "form_data")),
407 &actual); 410 &actual);
408 EXPECT_TRUE(form.form_data.SameFormAs(actual)); 411 EXPECT_TRUE(form.form_data.SameFormAs(actual));
409 } 412 }
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 EXPECT_EQ(form_google_, *form_list[0]); 927 EXPECT_EQ(form_google_, *form_list[0]);
925 928
926 EXPECT_EQ(1u, global_mock_libsecret_items->size()); 929 EXPECT_EQ(1u, global_mock_libsecret_items->size());
927 if (!global_mock_libsecret_items->empty()) { 930 if (!global_mock_libsecret_items->empty()) {
928 CheckMockSecretItem((*global_mock_libsecret_items)[0], form_google_, 931 CheckMockSecretItem((*global_mock_libsecret_items)[0], form_google_,
929 "chrome-42"); 932 "chrome-42");
930 } 933 }
931 } 934 }
932 935
933 // TODO(mdm): add more basic tests here at some point. 936 // TODO(mdm): add more basic tests here at some point.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698