chrome/browser/password_manager/password_store_mac.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret_unittest.cc ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.cc

diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc

index ed350b0ce4bda2f76f2dc28381f6797d90de14c9..dd567f8a5be1bc1fabc5f303a37b6cd8e4c488d5 100644

--- a/chrome/browser/password_manager/password_store_mac.cc

+++ b/chrome/browser/password_manager/password_store_mac.cc

@@ -243,7 +243,7 @@ inline void MoveAllFormsOut(ScopedVector<autofill::PasswordForm>* forms,

// True if the form has no password to be stored in Keychain.

bool IsLoginDatabaseOnlyForm(const autofill::PasswordForm& form) {

- return form.blacklisted_by_user || !form.federation_url.is_empty() ||

+ return form.blacklisted_by_user || !form.federation_origin.unique() ||

form.scheme == autofill::PasswordForm::SCHEME_USERNAME_ONLY;

}