Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1721943003: Move llvm from deps to deps_os (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use llvm instead of all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M DEPS View 1 1 chunk +10 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (4 generated)
bsalomon
4 years, 10 months ago (2016-02-23 17:03:55 UTC) #3
borenet
LGTM but needs a bot-side change to set the deps_os.
4 years, 10 months ago (2016-02-23 17:42:23 UTC) #4
bsalomon
On 2016/02/23 17:42:23, borenet wrote: > LGTM but needs a bot-side change to set the ...
4 years, 10 months ago (2016-02-23 21:00:52 UTC) #5
bsalomon
ping
4 years, 9 months ago (2016-03-02 15:52:24 UTC) #6
borenet
On 2016/03/02 15:52:24, bsalomon wrote: > ping Looking into it, sorry for delay.
4 years, 9 months ago (2016-03-02 16:11:13 UTC) #7
borenet
On 2016/03/02 16:11:13, borenet wrote: > On 2016/03/02 15:52:24, bsalomon wrote: > > ping > ...
4 years, 9 months ago (2016-03-02 16:33:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721943003/20001
4 years, 9 months ago (2016-03-10 13:18:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/2034) Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 9 months ago (2016-03-10 13:20:05 UTC) #12
borenet
4 years, 9 months ago (2016-03-10 13:38:22 UTC) #13
On 2016/03/10 13:20:05, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
> (JOB_FAILED,
>
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
>   Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
>
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
>   Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
> (JOB_FAILED,
>
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
>   Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
>
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

Re-uploaded as https://codereview.chromium.org/1782793003

Powered by Google App Engine
This is Rietveld 408576698