Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1728093005: Move Budgeted enum out of SkSurface, use in GrTextureProvider (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move Budgeted enum out of SkSurface, use in GrTextureProvider BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005 DOCS_PREVIEW= https://skia.org/?cl=1728093005 Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/5ec26ae9bfca635ccc98283aad5deda11519d826

Patch Set 1 #

Patch Set 2 : compiling #

Patch Set 3 : cleanup #

Patch Set 4 : more cleanup #

Patch Set 5 : rebase #

Patch Set 6 : reparent #

Patch Set 7 : add aliases for Chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -212 lines) Patch
M bench/nanobench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M cmake/example.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuSupport.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M experimental/fiddle/fiddle_main.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/bleed.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gm/dftext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/discard.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/image.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M gm/image_pict.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M gm/image_shader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/imagetoyuvplanes.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/surface.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/texdata.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobmixedsizes.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes3.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkSurface.h View 1 2 3 4 5 6 4 chunks +9 lines, -17 lines 0 comments Download
M include/core/SkTypes.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M include/gpu/GrTextureProvider.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M site/user/api/canvas.md View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkImageCacherator.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuResourcePriv.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 7 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 6 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/image/SkImagePriv.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 3 7 chunks +9 lines, -12 lines 0 comments Download
M src/image/SkSurface.cpp View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkSurface_Base.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M src/image/SkSurface_Gpu.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/utils/SkImageGeneratorUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipBoundsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/CopySurfaceTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/EGLImageTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/FloatingPointTextureTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/GrSurfaceTest.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests/ImageFilterCacheTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ImageTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/RectangleTextureTest.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 10 chunks +13 lines, -12 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M tests/SpecialImageTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 5 chunks +10 lines, -14 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/TextureStorageAllocator.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/VisualBench/WrappedBenchmark.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/kilobench/kilobench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 38 (22 generated)
bsalomon
Most of this is up there in the boring CL hall of fame. The interesting ...
4 years, 10 months ago (2016-02-25 02:50:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/60001
4 years, 10 months ago (2016-02-25 02:50:41 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
4 years, 10 months ago (2016-02-25 02:51:22 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/100001
4 years, 10 months ago (2016-02-25 03:54:38 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
4 years, 10 months ago (2016-02-25 03:55:05 UTC) #12
reed1
lgtm
4 years, 10 months ago (2016-02-25 14:26:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/100001
4 years, 10 months ago (2016-02-25 14:27:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
4 years, 10 months ago (2016-02-25 14:27:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/100001
4 years, 10 months ago (2016-02-25 14:28:38 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
4 years, 10 months ago (2016-02-25 14:28:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/100001
4 years, 10 months ago (2016-02-25 14:32:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/100001
4 years, 10 months ago (2016-02-25 14:32:50 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
4 years, 10 months ago (2016-02-25 14:33:31 UTC) #30
bsalomon
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1734043002/ by bsalomon@google.com. ...
4 years, 10 months ago (2016-02-25 14:51:43 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093005/120001
4 years, 10 months ago (2016-02-25 16:16:07 UTC) #36
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 16:33:22 UTC) #38
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/5ec26ae9bfca635ccc98283aad5deda11519d826

Powered by Google App Engine
This is Rietveld 408576698