When a surface is backed by an external render target force a copy on image snap

When a surface is backed by an external render target force a copy on image snap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694943002

Committed: https://skia.googlesource.com/skia/+/b2c0133caf0f03462385c19634281c351355c979

[bsalomon, 2016-02-12 22:16:31]

Description was changed from

==========
When a surface is backed by an external render target force a copy on image snap

BUG=skia:
==========

to

==========
When a surface is backed by an external render target force a copy on image snap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-23 21:03:12]

Description was changed from

==========
When a surface is backed by an external render target force a copy on image snap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
When a surface is backed by an external render target force a copy on image snap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-23 21:05:48]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-02-23 21:05:48]

This prevents the sksurface from rendering to a FBO other than than the one the
client provided us after an image snapshot.

[robertphillips, 2016-02-24 13:11:55]

lgtm + a dox request

https://codereview.chromium.org/1694943002/diff/1/src/image/SkSurface_Gpu.cpp
File src/image/SkSurface_Gpu.cpp (right):

https://codereview.chromium.org/1694943002/diff/1/src/image/SkSurface_Gpu.cpp...
src/image/SkSurface_Gpu.cpp:83: SkAutoTUnref<GrTexture> copy;
// When clients wrap an external FBO in a Surface we need to keep that resource
attached to the surface rather than passing it off to the snapped Image. This is
particularly relevant when the wrapped FBO is a hardware overlay.

?

[bsalomon, 2016-02-26 17:44:44]

https://codereview.chromium.org/1694943002/diff/1/src/image/SkSurface_Gpu.cpp
File src/image/SkSurface_Gpu.cpp (right):

https://codereview.chromium.org/1694943002/diff/1/src/image/SkSurface_Gpu.cpp...
src/image/SkSurface_Gpu.cpp:83: SkAutoTUnref<GrTexture> copy;
On 2016/02/24 13:11:54, robertphillips wrote:
> // When clients wrap an external FBO in a Surface we need to keep that
resource
> attached to the surface rather than passing it off to the snapped Image. This
is
> particularly relevant when the wrapped FBO is a hardware overlay.
> 
> ?

Added a comment.

[bsalomon, 2016-02-26 17:44:48]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-26 17:44:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1694943002/#ps40001
(title: "Fix accidental comment change")

[commit-bot: I haz the power, 2016-02-26 17:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 17:44:59]

This CL has an open dependency (Issue 1721943003 Patch 20001). Please resolve
the dependency and try again.

[bsalomon, 2016-02-26 18:06:46]

Patchset #4 (id:60001) has been deleted

[bsalomon, 2016-02-26 18:22:27]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-26 18:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1694943002/#ps80001
(title: "test git config branch.nollvm.skip-deps-uploads True")

[commit-bot: I haz the power, 2016-02-26 18:22:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694943002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694943002/80001

[commit-bot: I haz the power, 2016-02-26 18:37:29]

Description was changed from

==========
When a surface is backed by an external render target force a copy on image snap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
When a surface is backed by an external render target force a copy on image snap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b2c0133caf0f03462385c19634281c351355c979
==========

[commit-bot: I haz the power, 2016-02-26 18:37:32]

Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/b2c0133caf0f03462385c19634281c351355c979