Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1752973003: Only modify abort behavior to avoid debugger dialog on windows for bot builds. (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org, robertphillips, egdaniel, Brian Osman
Base URL:
https://skia.googlesource.com/skia@depsos
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Only modify abort behavior to avoid debugger dialog on windows for bot builds. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752973003 Committed: https://skia.googlesource.com/skia/+/ad514d00e5a65dadf9040d0cde4b897f565b5c19

Patch Set 1 #

Patch Set 2 : remove patch dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ports/SkMemory_malloc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
bsalomon
4 years, 9 months ago (2016-03-02 16:34:20 UTC) #3
djsollen
lgtm
4 years, 9 months ago (2016-03-02 16:39:46 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1721943003 Patch 20001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-02 16:39:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752973003/20001
4 years, 9 months ago (2016-03-02 22:30:37 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 22:44:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ad514d00e5a65dadf9040d0cde4b897f565b5c19

Powered by Google App Engine
This is Rietveld 408576698