Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 17204002: Revert 206020 "cc: Emulate BeginFrame in OutputSurfaces that don..." (Closed)

Created:
7 years, 6 months ago by reveman
Modified:
7 years, 6 months ago
Reviewers:
brianderson
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 206020 "cc: Emulate BeginFrame in OutputSurfaces that don..." This is causing pre-rendered pages to not load on android: crbug.com/249806 > cc: Emulate BeginFrame in OutputSurfaces that don't support it natively > > This includes two small fixes for the original version of this > patch that broke software compositing and WebView. > > This will allow us to avoid having two different code paths > in the Scheduler. It also allows us to more easily remove the > VSyncTimeSource and FrameRateController from the Scheduler. > > This patch instantiates the FrameRateController inside of > OutputSurface for now, but the FrameRateController could be > removed in future patches. > > BUG=245920 > BUG=243497 > TBR=nduca@chromium.org,sievers@chromium.org,kbr@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/16833003 TBR=brianderson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+544 lines, -717 lines) Patch
M trunk/src/cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/cc/cc_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/cc/output/output_surface.h View 7 chunks +6 lines, -38 lines 0 comments Download
M trunk/src/cc/output/output_surface.cc View 6 chunks +23 lines, -127 lines 0 comments Download
M trunk/src/cc/output/output_surface_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/cc/output/output_surface_unittest.cc View 9 chunks +12 lines, -147 lines 0 comments Download
M trunk/src/cc/scheduler/frame_rate_controller.h View 5 chunks +8 lines, -13 lines 0 comments Download
M trunk/src/cc/scheduler/frame_rate_controller.cc View 6 chunks +10 lines, -16 lines 0 comments Download
M trunk/src/cc/scheduler/frame_rate_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler.h View 5 chunks +18 lines, -14 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler.cc View 6 chunks +57 lines, -68 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/scheduler/scheduler_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine.h View 5 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine.cc View 7 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/scheduler/scheduler_unittest.cc View 18 chunks +170 lines, -113 lines 0 comments Download
A + trunk/src/cc/scheduler/vsync_time_source.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/cc/scheduler/vsync_time_source.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/cc/scheduler/vsync_time_source_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/cc/test/fake_output_surface.h View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/cc/test/fake_output_surface.cc View 6 chunks +5 lines, -21 lines 0 comments Download
M trunk/src/cc/test/layer_tree_test.h View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/cc/test/layer_tree_test.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/cc/test/scheduler_test_common.h View 1 chunk +30 lines, -0 lines 0 comments Download
M trunk/src/cc/test/scheduler_test_common.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.cc View 2 chunks +5 lines, -19 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest.cc View 4 chunks +58 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_animation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/cc/trees/proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.h View 10 chunks +29 lines, -12 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.cc View 9 chunks +58 lines, -51 lines 0 comments Download
M trunk/src/chrome/test/perf/rendering/latency_tests.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/content/browser/android/in_process/synchronous_compositor_output_surface.cc View 7 chunks +7 lines, -9 lines 0 comments Download
M trunk/src/content/browser/renderer_host/image_transport_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/gpu/compositor_output_surface.cc View 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reveman
7 years, 6 months ago (2013-06-17 01:40:07 UTC) #1
reveman
7 years, 6 months ago (2013-06-17 01:40:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r206655.

Powered by Google App Engine
This is Rietveld 408576698