Introduce BubbleDialogDelegateView, which extends DialogDelegateView

Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312
Committed: https://crrev.com/4c499dc1bed6d263ffd30dff5e9abab76ffc6094
Cr-Commit-Position: refs/heads/master@{#378545}

[Evan Stade, 2016-02-19 04:42:35]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[Evan Stade, 2016-02-19 22:17:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-02-22 18:40:14]

ping msw

[groby-ooo-7-16, 2016-02-22 18:47:14]

Description was changed from

==========
Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312
==========

to

==========
Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312
==========

[groby-ooo-7-16, 2016-02-22 18:47:14]

groby@chromium.org changed reviewers:
+ hcarmona@chromium.org

[groby-ooo-7-16, 2016-02-22 18:47:30]

groby@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2016-02-22 18:47:31]

CC'ed hcarmona as a heads-up. (For interaction with Bubble Manager)

[msw, 2016-02-22 21:43:57]

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/session_crashed_bubble_view.h (right):

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.h:34: class
SessionCrashedBubbleView : public SessionCrashedBubble,
Does the appearance of this bubble change at all?

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/simple_message_box_views.cc (left):

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/simple_message_box_views.cc:253: MessageBoxResult
ShowMessageBox(gfx::NativeWindow parent,
Did you intend to change this file? If so, how is it related?

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
File ui/views/bubble/bubble_dialog_delegate.cc (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.cc:55:
BubbleDialogDelegateView::BubbleDialogDelegateView()
nit: reorder to match decl (ditto for other ctor)

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.cc:119:
client->set_button_row_insets(gfx::Insets());
Why do we want empty insets here?

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
File ui/views/bubble/bubble_dialog_delegate.h (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.h:25: // should be used in place of
BubbleDelegateView as it shares more code with
Can you rephrase this sentence? Why does the code sharing dictate use of this
class over BubbleDelegateView? Do you want to simply say "BubbleDelegateView is
deprecated, use this instead." (or something to that effect above the
BubbleDelegateView decl instead)?

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (left):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:91: ok_button_->AddAccelerator(escape);
Is this behavior change necessary? It seems tangential.

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:342: // NOTE: The insets only apply to the
buttons, extra view, and footnote view.
nit: remove mention of footnote view

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.h (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.h:23: // the delegate's footnote view below
the buttons. The view appears like below.
nit: remove mention and depiction below of the footnote view.

[Evan Stade, 2016-02-22 22:58:23]

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/session_crashed_bubble_view.h (right):

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.h:34: class
SessionCrashedBubbleView : public SessionCrashedBubble,
On 2016/02/22 21:43:56, msw wrote:
> Does the appearance of this bubble change at all?

nope. Old on top, new on bottom:
https://screenshot.googleplex.com/mvqmHwrW3ef.png

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/simple_message_box_views.cc (left):

https://codereview.chromium.org/1717453003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/simple_message_box_views.cc:253: MessageBoxResult
ShowMessageBox(gfx::NativeWindow parent,
On 2016/02/22 21:43:56, msw wrote:
> Did you intend to change this file? If so, how is it related?

nope, sorry, this is tangential. I broke it off into another CL but accidentally
left some vestiges behind.

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
File ui/views/bubble/bubble_dialog_delegate.cc (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.cc:55:
BubbleDialogDelegateView::BubbleDialogDelegateView()
On 2016/02/22 21:43:56, msw wrote:
> nit: reorder to match decl (ditto for other ctor)

Done.

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.cc:119:
client->set_button_row_insets(gfx::Insets());
On 2016/02/22 21:43:56, msw wrote:
> Why do we want empty insets here?

Dialogs don't inset the client view at all. Bubbles do (see
CreateNonClientFrameView). Since there's already an inset on the
DialogClientView, it doesn't need to inset extra for the button strip.

Ideally we will be eventually able to remove this and just never have button
strip insets in DialogClientView, but that would require updating all dialogs to
inset their DCV instead of baking the padding into the content view's layout
(which is usually accomplished via GridLayout::CreatePanel).

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
File ui/views/bubble/bubble_dialog_delegate.h (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.h:25: // should be used in place of
BubbleDelegateView as it shares more code with
On 2016/02/22 21:43:56, msw wrote:
> Can you rephrase this sentence? Why does the code sharing dictate use of this
> class over BubbleDelegateView? Do you want to simply say "BubbleDelegateView
is
> deprecated, use this instead." (or something to that effect above the
> BubbleDelegateView decl instead)?

Done.

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (left):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:91: ok_button_->AddAccelerator(escape);
On 2016/02/22 21:43:56, msw wrote:
> Is this behavior change necessary? It seems tangential.

It's not a behavior change. I guess I forgot to explain this, sorry (it is
subtle). If we just add the accelerator to the overall dialog, it will call
DialogDelegate::Close() which will call Accept() if there's an OK but no CANCEL
button present. Hence, no real change.

It is necessary for this CL because it allows us to implement the behavior we
want in SessionCrashedBubbleView::Accept() (which is to distinguish between this
implicit Accept and an explicit Accept).

It occurs to me this is a bit half-baked as we don't even need to explicitly add
it to the Cancel button for the same reason. Updated.

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:342: // NOTE: The insets only apply to the
buttons, extra view, and footnote view.
On 2016/02/22 21:43:56, msw wrote:
> nit: remove mention of footnote view

I just removed the comment because it seems fairly self-evident

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.h (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.h:23: // the delegate's footnote view below
the buttons. The view appears like below.
On 2016/02/22 21:43:56, msw wrote:
> nit: remove mention and depiction below of the footnote view.

Done.

[msw, 2016-02-22 23:24:57]

lgtm

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
File ui/views/bubble/bubble_dialog_delegate.cc (right):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_dialog_delegate.cc:119:
client->set_button_row_insets(gfx::Insets());
On 2016/02/22 22:58:23, Evan Stade wrote:
> On 2016/02/22 21:43:56, msw wrote:
> > Why do we want empty insets here?
> 
> Dialogs don't inset the client view at all. Bubbles do (see
> CreateNonClientFrameView). Since there's already an inset on the
> DialogClientView, it doesn't need to inset extra for the button strip.
> 
> Ideally we will be eventually able to remove this and just never have button
> strip insets in DialogClientView, but that would require updating all dialogs
to
> inset their DCV instead of baking the padding into the content view's layout
> (which is usually accomplished via GridLayout::CreatePanel).

Acknowledged.

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (left):

https://codereview.chromium.org/1717453003/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:91: ok_button_->AddAccelerator(escape);
On 2016/02/22 22:58:23, Evan Stade wrote:
> On 2016/02/22 21:43:56, msw wrote:
> > Is this behavior change necessary? It seems tangential.
> 
> It's not a behavior change. I guess I forgot to explain this, sorry (it is
> subtle). If we just add the accelerator to the overall dialog, it will call
> DialogDelegate::Close() which will call Accept() if there's an OK but no
CANCEL
> button present. Hence, no real change.
> 
> It is necessary for this CL because it allows us to implement the behavior we
> want in SessionCrashedBubbleView::Accept() (which is to distinguish between
this
> implicit Accept and an explicit Accept).
> 
> It occurs to me this is a bit half-baked as we don't even need to explicitly
add
> it to the Cancel button for the same reason. Updated.

Hmm, okay; it seems like this should yield the same behavior.

[msw, 2016-02-22 23:26:47]

Oh sorry, I meant to call out the lack of tests.
Can you at least add a TODO to add/port tests like bubble_delegate_unittest.cc
(or maybe dialog_delegate_unittest.cc)

[Evan Stade, 2016-02-22 23:38:55]

On 2016/02/22 23:26:47, msw wrote:
> Oh sorry, I meant to call out the lack of tests.
> Can you at least add a TODO to add/port tests like bubble_delegate_unittest.cc
> (or maybe dialog_delegate_unittest.cc)

filed crbug.com/588877 (hopefully that's considered better than a TODO)

[Evan Stade, 2016-02-22 23:39:09]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-02-22 23:39:09]

over to sky for owners

[Evan Stade, 2016-02-22 23:39:17]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 23:41:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/60001

[commit-bot: I haz the power, 2016-02-22 23:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 23:45:23]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2016-02-23 17:56:16]

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (right):

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:57: button_row_insets_(gfx::Insets(0,
you shouldn't need the extra gfx::Insets here, that is:
button_row_insets(0, kButton...),

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
File ui/views/window/dialog_delegate.h (right):

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
ui/views/window/dialog_delegate.h:66: virtual scoped_ptr<View>
CreateFootnoteView();
The return value of this is fed into BubbleFrameView::SetFootnoteView, which
takes a scoped_ptr as well. Problem with both of these is that they don't really
take ownership, instead they add the view to a parent view. If the view has been
configured with set_owned_by_client(), then the view is not deleted. scoped_ptr
implies ownership, not ownership somes times.

Views have their own ownership policy that in some ways conflicts with
scoped_ptr. I don't think we should be using scoped_ptr here or in
BubbleFrameView.

[Evan Stade, 2016-02-23 19:02:37]

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view.cc (right):

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
ui/views/window/dialog_client_view.cc:57: button_row_insets_(gfx::Insets(0,
On 2016/02/23 17:56:15, sky wrote:
> you shouldn't need the extra gfx::Insets here, that is:
> button_row_insets(0, kButton...),

Done.

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
File ui/views/window/dialog_delegate.h (right):

https://codereview.chromium.org/1717453003/diff/60001/ui/views/window/dialog_...
ui/views/window/dialog_delegate.h:66: virtual scoped_ptr<View>
CreateFootnoteView();
On 2016/02/23 17:56:16, sky wrote:
> The return value of this is fed into BubbleFrameView::SetFootnoteView, which
> takes a scoped_ptr as well. Problem with both of these is that they don't
really
> take ownership, instead they add the view to a parent view. If the view has
been
> configured with set_owned_by_client(), then the view is not deleted.
scoped_ptr
> implies ownership, not ownership somes times.
> 
> Views have their own ownership policy that in some ways conflicts with
> scoped_ptr. I don't think we should be using scoped_ptr here or in
> BubbleFrameView.

ok, changed to bare pointer.

https://codereview.chromium.org/1717453003/diff/100001/ui/views/window/dialog...
File ui/views/window/dialog_delegate.h (left):

https://codereview.chromium.org/1717453003/diff/100001/ui/views/window/dialog...
ui/views/window/dialog_delegate.h:62: virtual View* CreateTitlebarExtraView();
this wasn't being used anywhere

[sky, 2016-02-23 21:22:23]

LGTM

[Evan Stade, 2016-02-23 21:26:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 21:31:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/100001

[commit-bot: I haz the power, 2016-02-23 22:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 22:11:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-02-25 02:19:25]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-02-25 02:19:25]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1717453003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-25 02:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/120001

[commit-bot: I haz the power, 2016-02-25 03:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 03:07:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-02-25 19:19:25]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-02-25 19:19:26]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1717453003/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-25 19:23:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/140001

[commit-bot: I haz the power, 2016-02-25 20:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 20:20:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Evan Stade, 2016-02-25 21:56:07]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-02-25 21:59:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/140001

[commit-bot: I haz the power, 2016-02-25 23:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 23:17:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Evan Stade, 2016-02-26 17:21:17]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 17:24:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/140001

[commit-bot: I haz the power, 2016-02-26 17:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 17:57:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-03-01 20:09:12]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-03-01 20:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1717453003/#ps180001
(title: ".")

[commit-bot: I haz the power, 2016-03-01 20:09:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717453003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717453003/180001

[commit-bot: I haz the power, 2016-03-01 20:16:39]

Description was changed from

==========
Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312
==========

to

==========
Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312
==========

[commit-bot: I haz the power, 2016-03-01 20:16:41]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-03-01 20:17:53]

Description was changed from

==========
Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312
==========

to

==========
Introduce BubbleDialogDelegateView, which extends DialogDelegateView
and shares more code with it than BubbleDelegateView.

The idea is to eventually replace BubbleDelegateView. I'd just have
modified BubbleDelegateView in place, but it requires updates to many
bubbles, so the two classes coexist for now.

This CL also removes redundant code in DialogClientView for laying out
the footnote view. I verified this doesn't affect the one place that
was using the code (CardUnmaskPromptViews).

SessionCrashedBubbleView is the only bubble using the new parent class
so far. It got a bit simpler because it didn't have to reimplement the
button strip.

BUG=585312

Committed: https://crrev.com/4c499dc1bed6d263ffd30dff5e9abab76ffc6094
Cr-Commit-Position: refs/heads/master@{#378545}
==========

[commit-bot: I haz the power, 2016-03-01 20:17:55]

Patchset 10 (id:??) landed as
https://crrev.com/4c499dc1bed6d263ffd30dff5e9abab76ffc6094
Cr-Commit-Position: refs/heads/master@{#378545}