chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc - Issue 1717453003: Introduce BubbleDialogDelegateView, which extends DialogDelegateView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

Issue 1717453003: Introduce BubbleDialogDelegateView, which extends DialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

index 523516d8a230c68aeb5e78899f99f670c9895c68..00f20196a7eb0eaf413045b9c42f9c6e29632e00 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

@@ -87,14 +87,15 @@ TEST_F(BookmarkBubbleViewTest, SyncPromoSignedIn) {

SetUpSigninManager("fake_username");

CreateBubbleView();

bubble_->Init();

- EXPECT_FALSE(bubble_->CreateFootnoteView());

+ scoped_ptr<views::View> footnote(bubble_->CreateFootnoteView());

+ EXPECT_FALSE(footnote);

}

// Verifies that the sync promo is displayed for a user that is not signed in.

TEST_F(BookmarkBubbleViewTest, SyncPromoNotSignedIn) {

CreateBubbleView();

bubble_->Init();

- scoped_ptr<views::View> footnote = bubble_->CreateFootnoteView();

+ scoped_ptr<views::View> footnote(bubble_->CreateFootnoteView());

#if defined(OS_CHROMEOS)

EXPECT_FALSE(footnote);

#else // !defined(OS_CHROMEOS)