Introduce BubbleDialogDelegateView, which extends DialogDelegateView

chrome/browser/ui/views/simple_message_box_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/simple_message_box.h"
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 232 matching lines @@
                                 );
   constrained_window::CreateBrowserModalDialogViews(dialog, parent)->Show();
 
   // NOTE: |dialog| may have been deleted by the time |RunDialogAndGetResult()|
   // returns.
   return dialog->RunDialogAndGetResult();
 }
 
 }  // namespace
 
-MessageBoxResult ShowMessageBox(gfx::NativeWindow parent,

[msw, 2016/02/22 21:43:56]

Did you intend to change this file? If so, how is it related?

[Evan Stade, 2016/02/22 22:58:22]

nope, sorry, this is tangential. I broke it off into another CL but accidentally
left some vestiges behind.

-                                const base::string16& title,
-                                const base::string16& message,
-                                MessageBoxType type) {
-  return ShowMessageBoxImpl(
-      parent, title, message, type, base::string16(), base::string16());
+void ShowWarningMessageBox(gfx::NativeWindow parent,
+                           const base::string16& title,
+                           const base::string16& message) {
+  ShowMessageBoxImpl(parent, title, message, MESSAGE_BOX_TYPE_WARNING,
+                     base::string16(), base::string16());
+}
+
+MessageBoxResult ShowQuestionMessageBox(gfx::NativeWindow parent,
+                                        const base::string16& title,
+                                        const base::string16& message) {
+  return ShowMessageBoxImpl(parent, title, message, MESSAGE_BOX_TYPE_QUESTION,
+                            base::string16(), base::string16());
 }
 
 MessageBoxResult ShowMessageBoxWithButtonText(gfx::NativeWindow parent,
                                               const base::string16& title,
                                               const base::string16& message,
                                               const base::string16& yes_text,
                                               const base::string16& no_text) {
   return ShowMessageBoxImpl(
       parent, title, message, MESSAGE_BOX_TYPE_QUESTION, yes_text, no_text);
 }
 
 }  // namespace chrome