Introduce BubbleDialogDelegateView, which extends DialogDelegateView

ui/views/window/dialog_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WINDOW_DIALOG_DELEGATE_H_
 #define UI_VIEWS_WINDOW_DIALOG_DELEGATE_H_
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
@@ skipping 45 matching lines @@
   // If a custom padding should be used, returns true and populates |padding|.
   virtual bool GetExtraViewPadding(int* padding);
 
   // Override this function to display an extra view in the titlebar.
   // Overrides may construct the view; this will only be called once per dialog.
   // Note: this only works for new style dialogs.
   virtual View* CreateTitlebarExtraView();
 
   // Override this function to display a footnote view below the buttons.
   // Overrides may construct the view; this will only be called once per dialog.
-  virtual View* CreateFootnoteView();
+  virtual scoped_ptr<View> CreateFootnoteView();

[sky, 2016/02/23 17:56:16]

The return value of this is fed into BubbleFrameView::SetFootnoteView, which
takes a scoped_ptr as well. Problem with both of these is that they don't really
take ownership, instead they add the view to a parent view. If the view has been
configured with set_owned_by_client(), then the view is not deleted. scoped_ptr
implies ownership, not ownership somes times.

Views have their own ownership policy that in some ways conflicts with
scoped_ptr. I don't think we should be using scoped_ptr here or in
BubbleFrameView.

[Evan Stade, 2016/02/23 19:02:36]

ok, changed to bare pointer.

 
   // For Dialog boxes, if there is a "Cancel" button or no dialog button at all,
   // this is called when the user presses the "Cancel" button or the Esc key.
   // It can also be called on a close action if |Close| has not been
   // overridden. This function should return true if the window can be closed
   // after it returns, or false if it must remain open.
   virtual bool Cancel();
 
   // For Dialog boxes, this is called when the user presses the "OK" button,
   // or the Enter key. It can also be called on a close action if |Close|
@@ skipping 67 matching lines @@
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DialogDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WINDOW_DIALOG_DELEGATE_H_