Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1714043003: Settings People Revamp: Change Picture Minor accessibility upgrades (Closed)

Created:
4 years, 10 months ago by tommycli
Modified:
4 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Change Picture Minor accessibility upgrades 1) Add announcement messages that were missing. 2) Normalize alt-text specification. 3) Normalize tab-index. 4) Add missing loaded profile image alt text. 5) Fix profile image being shown (incorrectly) when selecting File icon. BUG=563721 Committed: https://crrev.com/747bb83792d0b3772f55e4bf9950b42c8db0cc05 Cr-Commit-Position: refs/heads/master@{#376586}

Patch Set 1 #

Patch Set 2 : Also fix preview image being shown at wrong times. #

Patch Set 3 : fix closure compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/camera.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/camera.js View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.js View 1 4 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/compiled_resources.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
tommycli
Hello hcarmona: PTAL. Small fixes to accessibility of Change Picture subpage. Thanks!
4 years, 10 months ago (2016-02-19 20:23:52 UTC) #2
tommycli
stevenjb: PTAL small accessibility fixes.
4 years, 10 months ago (2016-02-19 22:39:52 UTC) #5
stevenjb
lgtm
4 years, 10 months ago (2016-02-19 23:37:00 UTC) #6
tommycli
On 2016/02/19 23:37:00, stevenjb wrote: > lgtm stevenjb: thanks for the lightning fast review
4 years, 10 months ago (2016-02-19 23:39:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714043003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714043003/40001
4 years, 10 months ago (2016-02-19 23:42:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-20 00:40:43 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 00:41:48 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/747bb83792d0b3772f55e4bf9950b42c8db0cc05
Cr-Commit-Position: refs/heads/master@{#376586}

Powered by Google App Engine
This is Rietveld 408576698