Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7425)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.html

Issue 1714043003: Settings People Revamp: Change Picture Minor accessibility upgrades (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix closure compile Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/change_picture.html
diff --git a/chrome/browser/resources/settings/people_page/change_picture.html b/chrome/browser/resources/settings/people_page/change_picture.html
index 2554f1581e9382932b5f24b089af6db80c0ff7a3..68e1675ac651635cf4f4d320a99834ba6f403476 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.html
+++ b/chrome/browser/resources/settings/people_page/change_picture.html
@@ -1,4 +1,5 @@
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
+<link rel="import" href="chrome://resources/html/util.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/image-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-selector.html">
@@ -17,14 +18,13 @@
<iron-selector id="selector" on-iron-activate="onImageActivate_"
selected-item="{{selectedItem_}}">
<iron-icon id="cameraImage" data-type="camera" icon="image:camera-alt"
- alt="[[i18n('takePhoto')]]" hidden="[[!cameraPresent_]]">
+ i18n-values="alt:takePhoto" hidden="[[!cameraPresent_]]">
</iron-icon>
<iron-icon data-type="file" icon="folder"
- alt="[[i18n('chooseFile')]]">
+ i18n-values="alt:chooseFile">
</iron-icon>
<img id="profileImage" data-type="profile"
- src="[[profileImageUrl_]]"
- alt="[[i18n('profilePhotoLoading')]]">
+ src="[[profileImageUrl_]]" i18n-values="alt:profilePhotoLoading">
<img id="oldImage" data-type="old"
src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]">
<template is="dom-repeat" items="[[defaultImages_]]">
@@ -45,9 +45,9 @@
</div>
<div id="previewPane">
<img i18n-values="alt:previewAltText" src="[[selectedItem_.src]]"
- hidden="[[isCameraActive_(cameraPresent_, selectedItem_)]]">
+ hidden="[[isPreviewImageHidden_(selectedItem_)]]">
<div id="discardControlBar" hidden="[[isDiscardHidden_(selectedItem_)]]">
- <paper-icon-button id="discardOldImage" tabindex="2" icon="delete"
+ <paper-icon-button id="discardOldImage" tabindex="0" icon="delete"
i18n-values="title:discardPhoto" on-tap="onTapDiscardOldImage_">
</paper-icon-button>
</div>

Powered by Google App Engine
This is Rietveld 408576698