Settings People Revamp: Change Picture Minor accessibility upgrades

chrome/browser/resources/settings/people_page/change_picture.html

 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
+<link rel="import" href="chrome://resources/html/util.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/image-icons.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-selector.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
 <link rel="import" href="chrome://md-settings/people_page/camera.html">
 <link rel="import" href="chrome://md-settings/people_page/change_picture_private_api.html">
 
 <dom-module id="settings-change-picture">
   <link rel="import" type="css"
       href="chrome://md-settings/settings_shared.css">
   <link rel="import" type="css" href="change_picture.css">
   <template>
     <div id="container" class="settings-box">
       <div id="availableIcons" class="start">
         <iron-selector id="selector" on-iron-activate="onImageActivate_"
             selected-item="{{selectedItem_}}">
           <iron-icon id="cameraImage" data-type="camera" icon="image:camera-alt"
-              alt="[[i18n('takePhoto')]]" hidden="[[!cameraPresent_]]">
+              i18n-values="alt:takePhoto" hidden="[[!cameraPresent_]]">
           </iron-icon>
           <iron-icon data-type="file" icon="folder"
-              alt="[[i18n('chooseFile')]]">
+              i18n-values="alt:chooseFile">
           </iron-icon>
           <img id="profileImage" data-type="profile"
-              src="[[profileImageUrl_]]"
-              alt="[[i18n('profilePhotoLoading')]]">
+              src="[[profileImageUrl_]]" i18n-values="alt:profilePhotoLoading">
           <img id="oldImage" data-type="old"
               src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]">
           <template is="dom-repeat" items="[[defaultImages_]]">
             <img data-type="default" data-default-image-index$="[[index]]"
                 src="[[item.url]]" alt="[[item.title]]">
           </template>
         </iron-selector>
         <template is="dom-if" if="[[isAuthorCreditShown_(selectedItem_)]]">
           <div id="authorCredit">
             [[i18n('authorCredit')]]
             [[getAuthorName_(selectedItem_, defaultImages_)]]
             <a href="[[getAuthorWebsite_(selectedItem_, defaultImages_)]]"
                 target="_blank">
               [[getAuthorWebsite_(selectedItem_, defaultImages_)]]
             </a>
           </div>
         </template>
       </div>
       <div id="previewPane">
         <img i18n-values="alt:previewAltText" src="[[selectedItem_.src]]"
-            hidden="[[isCameraActive_(cameraPresent_, selectedItem_)]]">
+            hidden="[[isPreviewImageHidden_(selectedItem_)]]">
         <div id="discardControlBar" hidden="[[isDiscardHidden_(selectedItem_)]]">
-          <paper-icon-button id="discardOldImage" tabindex="2" icon="delete"
+          <paper-icon-button id="discardOldImage" tabindex="0" icon="delete"
               i18n-values="title:discardPhoto" on-tap="onTapDiscardOldImage_">
           </paper-icon-button>
         </div>
         <settings-camera
             camera-active="[[isCameraActive_(cameraPresent_, selectedItem_)]]"
             on-phototaken="onPhotoTaken_">
       </div>
     </div>
   </template>
   <script src="change_picture.js"></script>
 </dom-module>