chrome/browser/resources/settings/people_page/camera.js - Issue 1714043003: Settings People Revamp: Change Picture Minor accessibility upgrades

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/camera.js

Issue 1714043003: Settings People Revamp: Change Picture Minor accessibility upgrades (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix closure compile Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/camera.html ('k') | chrome/browser/resources/settings/people_page/change_picture.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/camera.js

diff --git a/chrome/browser/resources/settings/people_page/camera.js b/chrome/browser/resources/settings/people_page/camera.js

index 97c8cf4e865c2880d3cda4667a8bfd69ac783a41..b403884d4a638a823c3cefbffbf9fcf1b4e0ae86 100644

--- a/chrome/browser/resources/settings/people_page/camera.js

+++ b/chrome/browser/resources/settings/people_page/camera.js

@@ -134,7 +134,9 @@ Polymer({

this.isFlipped_ = !this.isFlipped_;

this.$.userImageStreamCrop.classList.toggle('flip-x', this.isFlipped_);

- // TODO(tommycli): Add announce of accessible message for photo flipping.

+ var flipMessageId = this.isFlipped_ ?

+ 'photoFlippedAccessibleText' : 'photoFlippedBackAccessibleText';

+ announceAccessibleMessage(loadTimeData.getString(flipMessageId));

/**

@@ -157,6 +159,9 @@ Polymer({

var photoDataUrl = this.isFlipped_ ? this.flipFrame_(canvas) :

canvas.toDataURL('image/png');

this.fire('phototaken', {photoDataUrl: photoDataUrl});

+ announceAccessibleMessage(

+ loadTimeData.getString('photoCaptureAccessibleText'));

/**