Remove CFX_{Byte,Wide}String::ConvertFrom().

Remove CFX_{Byte,Wide}String::ConvertFrom().

Use/add CFX_{Byte,Wide}String::FromFoo() instead.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/31c7b73b71bd7352f96a82716b5e81d7fa24f37f

[Lei Zhang, 2016-02-19 00:43:53]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-02-19 17:02:47]

lgtm

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.cpp
File core/src/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:25: static void
FPDFDOC_FDF_GetFieldValue(CPDF_Dictionary* pFieldDict,
Nit: need not be static now that namespace'd anon.

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:30: size_t i = 0;
Nit: maybe range-based for-loop.

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:33: break;
Nit: maybe do line 36 here and return rather than break and retest.

https://codereview.chromium.org/1711893003/diff/1/core/src/fxcrt/fx_basic_bst...
File core/src/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1711893003/diff/1/core/src/fxcrt/fx_basic_bst...
core/src/fxcrt/fx_basic_bstring.cpp:917: FX_STRSIZE str_len = len >= 0 ? len :
FXSYS_wcslen(str);
Follow-up: the len == -1 convention for unknown length makes it hard to convert
lengths to unsigned types down the road (unless you want some notion of npos). 
What would it take to split this into two forms, one where the length is known
and a single-argument form where it isn't?  Meh.

[Lei Zhang, 2016-02-19 18:48:34]

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.cpp
File core/src/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:25: static void
FPDFDOC_FDF_GetFieldValue(CPDF_Dictionary* pFieldDict,
On 2016/02/19 17:02:47, Tom Sepez wrote:
> Nit: need not be static now that namespace'd anon.

Done.

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:30: size_t i = 0;
On 2016/02/19 17:02:47, Tom Sepez wrote:
> Nit: maybe range-based for-loop.

Done, and more.

https://codereview.chromium.org/1711893003/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:33: break;
On 2016/02/19 17:02:47, Tom Sepez wrote:
> Nit: maybe do line 36 here and return rather than break and retest.

Done.

https://codereview.chromium.org/1711893003/diff/1/core/src/fxcrt/fx_basic_bst...
File core/src/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1711893003/diff/1/core/src/fxcrt/fx_basic_bst...
core/src/fxcrt/fx_basic_bstring.cpp:917: FX_STRSIZE str_len = len >= 0 ? len :
FXSYS_wcslen(str);
On 2016/02/19 17:02:47, Tom Sepez wrote:
> Follow-up: the len == -1 convention for unknown length makes it hard to
convert
> lengths to unsigned types down the road (unless you want some notion of npos).

> What would it take to split this into two forms, one where the length is known
> and a single-argument form where it isn't?  Meh.

There's a ton of these in the code base. Probably for another time.

[Lei Zhang, 2016-02-19 18:53:33]

Description was changed from

==========
Remove CFX_{Byte,Wide}String::ConvertFrom().

Use/add CFX_{Byte,Wide}String::FromFoo() instead.
==========

to

==========
Remove CFX_{Byte,Wide}String::ConvertFrom().

Use/add CFX_{Byte,Wide}String::FromFoo() instead.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/31c7b73b71bd7352f96a82716b5e81d7fa24...
==========

[Lei Zhang, 2016-02-19 18:53:34]

Committed patchset #3 (id:40001) manually as
31c7b73b71bd7352f96a82716b5e81d7fa24f37f (presubmit successful).