core/src/fxcrt/fx_extension.cpp - Issue 1711893003: Remove CFX_{Byte,Wide}String::ConvertFrom().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_extension.cpp

Issue 1711893003: Remove CFX_{Byte,Wide}String::ConvertFrom(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_extension.cpp

diff --git a/core/src/fxcrt/fx_extension.cpp b/core/src/fxcrt/fx_extension.cpp

index fa6245c9d32a1ba6b3f588080fb69a15ea817b5d..cae1763c7ee573796287f0b4b1986c8f8572dffb 100644

--- a/core/src/fxcrt/fx_extension.cpp

+++ b/core/src/fxcrt/fx_extension.cpp

@@ -133,7 +133,8 @@ FX_FLOAT FXSYS_strtof(const FX_CHAR* pcsStr,

if (iLength < 0) {

iLength = (int32_t)FXSYS_strlen(pcsStr);

}

- CFX_WideString ws = CFX_WideString::FromLocal(pcsStr, iLength);

+ CFX_WideString ws =

+ CFX_WideString::FromLocal(CFX_ByteString(pcsStr, iLength));

return FXSYS_wcstof(ws.c_str(), iLength, pUsedLen);

}

FX_FLOAT FXSYS_wcstof(const FX_WCHAR* pwsStr,

« no previous file with comments | « core/src/fxcrt/fx_basic_wstring.cpp ('k') | xfa/src/fgas/src/crt/fx_system.cpp » ('j') | no next file with comments »