Remove CFX_{Byte,Wide}String::ConvertFrom().

core/src/fpdfdoc/doc_basic_unittest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/include/fpdfdoc/fpdf_doc.h"
 
 #include <memory>
 #include <vector>
 
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 127 matching lines @@
 #else
     L"/docs/test.pdf",
     L"/docs/test.pdf"
 #endif
   };
   // String object.
   ScopedObj str_obj(new CPDF_String(L"babababa"));
   CPDF_FileSpec file_spec1(str_obj.get());
   file_spec1.SetFileName(test_data.input);
   // Check internal object value.
-  CFX_ByteString str;
-  str.ConvertFrom(test_data.expected);
+  CFX_ByteString str = CFX_ByteString::FromUnicode(test_data.expected);
   EXPECT_TRUE(str == str_obj->GetString());
   // Check we can get the file name back.
   CFX_WideString file_name;
   EXPECT_TRUE(file_spec1.GetFileName(&file_name));
   EXPECT_TRUE(file_name.Equal(test_data.input));
 
   // Dictionary object.
   ScopedDict dict_obj(new CPDF_Dictionary);
   CPDF_FileSpec file_spec2(dict_obj.get());
   file_spec2.SetFileName(test_data.input);
   // Check internal object value.
   file_name = dict_obj->GetUnicodeTextBy("F");
   EXPECT_TRUE(file_name.Equal(test_data.expected));
   file_name = dict_obj->GetUnicodeTextBy("UF");
   EXPECT_TRUE(file_name.Equal(test_data.expected));
   // Check we can get the file name back.
   EXPECT_TRUE(file_spec2.GetFileName(&file_name));
   EXPECT_TRUE(file_name.Equal(test_data.input));
 }