Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1709543003: Tell _incremental targets to fail fast when load_library_from_apk=true (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tell _incremental targets to fail fast when load_library_from_apk=true BUG=587584 Committed: https://crrev.com/c578713be9c4b1d02938405af650f59a40a8716d Cr-Commit-Position: refs/heads/master@{#376165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M build/android/incremental_install/create_install_script.py View 4 chunks +9 lines, -2 lines 0 comments Download
M build/android/incremental_install/installer.py View 2 chunks +6 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
agrieve
On 2016/02/17 21:00:11, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:mlamouri@chromium.org Managed to get ...
4 years, 10 months ago (2016-02-17 21:00:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709543003/1
4 years, 10 months ago (2016-02-17 21:04:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 22:29:02 UTC) #7
mlamouri (slow - plz ping)
lgtm
4 years, 10 months ago (2016-02-18 11:59:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709543003/1
4 years, 10 months ago (2016-02-18 14:34:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 14:40:14 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 14:41:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c578713be9c4b1d02938405af650f59a40a8716d
Cr-Commit-Position: refs/heads/master@{#376165}

Powered by Google App Engine
This is Rietveld 408576698