Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: build/config/android/rules.gni

Issue 1709543003: Tell _incremental targets to fail fast when load_library_from_apk=true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/incremental_install/installer.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//base/android/linker/config.gni") 5 import("//base/android/linker/config.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/internal_rules.gni") 7 import("//build/config/android/internal_rules.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/toolchain.gni") 9 import("//build/toolchain/toolchain.gni")
10 import("//third_party/android_platform/config.gni") 10 import("//third_party/android_platform/config.gni")
(...skipping 1901 matching lines...) Expand 10 before | Expand all | Expand 10 after
1912 _rebased_extra_native_libs = 1912 _rebased_extra_native_libs =
1913 rebase_path(_extra_native_libs, root_build_dir) 1913 rebase_path(_extra_native_libs, root_build_dir)
1914 args += [ "--native-libs=$_rebased_extra_native_libs" ] 1914 args += [ "--native-libs=$_rebased_extra_native_libs" ]
1915 } 1915 }
1916 if (_create_density_splits) { 1916 if (_create_density_splits) {
1917 args += [ "--split=${_rebased_apk_path_no_ext}-density-*.apk" ] 1917 args += [ "--split=${_rebased_apk_path_no_ext}-density-*.apk" ]
1918 } 1918 }
1919 if (_create_language_splits) { 1919 if (_create_language_splits) {
1920 args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ] 1920 args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ]
1921 } 1921 }
1922 if (_load_library_from_apk) {
1923 args += [ "--dont-even-try=Incremental builds do not work with load_librar y_from_apk. Try setting is_component_build=true in your GN args." ]
1924 }
1922 } 1925 }
1923 1926
1924 group(target_name) { 1927 group(target_name) {
1925 forward_variables_from(invoker, [ "data_deps" ]) 1928 forward_variables_from(invoker, [ "data_deps" ])
1926 public_deps = _final_deps 1929 public_deps = _final_deps
1927 } 1930 }
1928 group("${target_name}_incremental") { 1931 group("${target_name}_incremental") {
1929 data_deps = [] 1932 data_deps = []
1930 forward_variables_from(invoker, [ "data_deps" ]) 1933 forward_variables_from(invoker, [ "data_deps" ])
1931 1934
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
2413 "--target", 2416 "--target",
2414 rebase_path(invoker.target, root_build_dir), 2417 rebase_path(invoker.target, root_build_dir),
2415 "--output-directory", 2418 "--output-directory",
2416 rebase_path(root_out_dir, root_build_dir), 2419 rebase_path(root_out_dir, root_build_dir),
2417 ] 2420 ]
2418 if (defined(invoker.flag_name)) { 2421 if (defined(invoker.flag_name)) {
2419 args += [ "--flag-name=${invoker.flag_name}" ] 2422 args += [ "--flag-name=${invoker.flag_name}" ]
2420 } 2423 }
2421 } 2424 }
2422 } 2425 }
OLDNEW
« no previous file with comments | « build/android/incremental_install/installer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698