Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2174)

Unified Diff: build/config/android/rules.gni

Issue 1709543003: Tell _incremental targets to fail fast when load_library_from_apk=true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/incremental_install/installer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index a280be3b689b5fa15bb2f110573597ffc8ee58c4..c9db22a5b67aa4a3fef38e520f4cc9cec2a240d2 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1919,6 +1919,9 @@ template("android_apk") {
if (_create_language_splits) {
args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ]
}
+ if (_load_library_from_apk) {
+ args += [ "--dont-even-try=Incremental builds do not work with load_library_from_apk. Try setting is_component_build=true in your GN args." ]
+ }
}
group(target_name) {
« no previous file with comments | « build/android/incremental_install/installer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698