Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Unified Diff: build/android/incremental_install/installer.py

Issue 1709543003: Tell _incremental targets to fail fast when load_library_from_apk=true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/incremental_install/create_install_script.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/incremental_install/installer.py
diff --git a/build/android/incremental_install/installer.py b/build/android/incremental_install/installer.py
index b5b1d050e5510261198775f8e5fe52a2a743bff4..2f60a9af7b98aa242a18b53b975172966af6dd28 100755
--- a/build/android/incremental_install/installer.py
+++ b/build/android/incremental_install/installer.py
@@ -262,6 +262,8 @@ def main():
action='store_true',
default=False,
help='Print a warning about proguard being disabled')
+ parser.add_argument('--dont-even-try',
+ help='Prints this message and exits.')
parser.add_argument('-v',
'--verbose',
dest='verbose_count',
@@ -278,6 +280,10 @@ def main():
devil_chromium.Initialize(output_directory=constants.GetOutDirectory())
+ if args.dont_even_try:
+ logging.fatal(args.dont_even_try)
+ return 1
+
if args.device:
# Retries are annoying when commands fail for legitimate reasons. Might want
# to enable them if this is ever used on bots though.
« no previous file with comments | « build/android/incremental_install/create_install_script.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698