Remove PageObject's m_Type and add As<Type> functions

Remove PageObject's m_Type and add As<Type> functions

For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead. Also, add As<Type> functions to avoid casting all over the places.

BUG=pdfium:397
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/7cf13c9c8b9b69b01e5debb5e8dc8b265983dfa8

[Wei Li, 2016-02-19 03:15:25]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-02-19 03:18:10]

Description was changed from

==========
Remove m_Type and add As<Type> functions to avoid casting.

BUG=397
==========

to

==========
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=397
==========

[Wei Li, 2016-02-19 03:38:23]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-02-19 03:38:24]

PTAL, thanks

[Lei Zhang, 2016-02-19 04:22:31]

lgtm

https://codereview.chromium.org/1709393002/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1709393002/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:325: if (type !=
CPDF_PageObject::IMAGE) {
Maybe just remove the type parameter and this check? The only caller on line 310
above behaves as though we never return NULL here.

https://codereview.chromium.org/1709393002/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:379: bRet =
ProcessText((CPDF_TextObject*)pObj, pObj2Device, NULL);
More casts to get rid of.

https://codereview.chromium.org/1709393002/diff/20001/fpdfsdk/src/fpdfeditpag...
File fpdfsdk/src/fpdfeditpage.cpp (right):

https://codereview.chromium.org/1709393002/diff/20001/fpdfsdk/src/fpdfeditpag...
fpdfsdk/src/fpdfeditpage.cpp:145: CPDF_PathObject* pPathObj =
(CPDF_PathObject*)pPageObj;
More casts.

[Lei Zhang, 2016-02-19 04:24:30]

Description was changed from

==========
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=397
==========

to

==========
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=pdfium:397
==========

[Lei Zhang, 2016-02-19 04:25:14]

BTW, I changed the CL description. If one writes BUG=397, the Chromium code
review tool assumes Chromium bug 397 by default.

[Wei Li, 2016-02-19 19:32:19]

thanks! I also propagated the constness along the functions while making the
change.

https://codereview.chromium.org/1709393002/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1709393002/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:325: if (type !=
CPDF_PageObject::IMAGE) {
On 2016/02/19 04:22:31, Lei Zhang wrote:
> Maybe just remove the type parameter and this check? The only caller on line
310
> above behaves as though we never return NULL here.

I removed it for now. Looks like IPDF_ObjectRenderer is only used by
ImageRender, maybe we could get rid of it all later.

https://codereview.chromium.org/1709393002/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:379: bRet =
ProcessText((CPDF_TextObject*)pObj, pObj2Device, NULL);
On 2016/02/19 04:22:31, Lei Zhang wrote:
> More casts to get rid of.

Thanks for spotting these. Done.

https://codereview.chromium.org/1709393002/diff/20001/fpdfsdk/src/fpdfeditpag...
File fpdfsdk/src/fpdfeditpage.cpp (right):

https://codereview.chromium.org/1709393002/diff/20001/fpdfsdk/src/fpdfeditpag...
fpdfsdk/src/fpdfeditpage.cpp:145: CPDF_PathObject* pPathObj =
(CPDF_PathObject*)pPageObj;
On 2016/02/19 04:22:31, Lei Zhang wrote:
> More casts.

Done.

[Lei Zhang, 2016-02-19 19:37:49]

++lgtm

[Lei Zhang, 2016-02-19 19:38:45]

Description was changed from

==========
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=pdfium:397
==========

to

==========
Remove PageObject's m_Type and add As<Type> functions

For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=pdfium:397
==========

[Wei Li, 2016-02-19 19:53:06]

Description was changed from

==========
Remove PageObject's m_Type and add As<Type> functions

For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=pdfium:397
==========

to

==========
Remove PageObject's m_Type and add As<Type> functions

For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead.
Also, add As<Type> functions to avoid casting all over the places.

BUG=pdfium:397
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/7cf13c9c8b9b69b01e5debb5e8dc8b265983...
==========

[Wei Li, 2016-02-19 19:53:08]

Committed patchset #2 (id:40001) manually as
7cf13c9c8b9b69b01e5debb5e8dc8b265983dfa8 (presubmit successful).

[Wei Li, 2016-02-22 20:25:12]

Patchset #3 (id:60001) has been deleted