core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp - Issue 1709393002: Remove PageObject's m_Type and add As<Type> functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

Issue 1709393002: Remove PageObject's m_Type and add As<Type> functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

index 01322b5c1ffd7f6bbe53533dee2aacef36c9700c..93c0aca4f1bf6f7f24357f01a26ecbfb1eee5453 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

@@ -9,8 +9,7 @@

#include "core/include/fpdfapi/fpdf_page.h"

#include "core/include/fpdfapi/fpdf_pageobj.h"

-CPDF_ImageObject::CPDF_ImageObject()

- : CPDF_PageObject(IMAGE), m_pImage(nullptr) {}

+CPDF_ImageObject::CPDF_ImageObject() : m_pImage(nullptr) {}

CPDF_ImageObject::~CPDF_ImageObject() {

if (!m_pImage) {

return;