Remove PageObject's m_Type and add As<Type> functions

core/src/fpdftext/fpdf_text_int.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/src/fpdftext/text_int.h"
 
 #include <algorithm>
 #include <cctype>
@@ skipping 747 matching lines @@
   std::vector<uint8_t> nHorizontalMask(nPageWidth);
   std::vector<uint8_t> nVerticalMask(nPageHeight);
   uint8_t* pDataH = nHorizontalMask.data();
   uint8_t* pDataV = nVerticalMask.data();
   int32_t index = 0;
   FX_FLOAT fLineHeight = 0.0f;
   if (m_pPage->GetPageObjectList()->empty())
     return -1;
 
   for (auto& pPageObj : *m_pPage->GetPageObjectList()) {
-    if (!pPageObj || pPageObj->m_Type != CPDF_PageObject::TEXT)
+    if (!pPageObj || !pPageObj->IsText())
       continue;
 
     int32_t minH =
         (int32_t)pPageObj->m_Left < 0 ? 0 : (int32_t)pPageObj->m_Left;
     int32_t maxH = (int32_t)pPageObj->m_Right > nPageWidth
                        ? nPageWidth
                        : (int32_t)pPageObj->m_Right;
     int32_t minV =
         (int32_t)pPageObj->m_Bottom < 0 ? 0 : (int32_t)pPageObj->m_Bottom;
     int32_t maxV = (int32_t)pPageObj->m_Top > nPageHeight
@@ skipping 60 matching lines @@
 }
 
 void CPDF_TextPage::ProcessObject() {
   if (m_pPage->GetPageObjectList()->empty())
     return;
 
   m_TextlineDir = FindTextlineFlowDirection();
   const CPDF_PageObjectList* pObjList = m_pPage->GetPageObjectList();
   for (auto it = pObjList->begin(); it != pObjList->end(); ++it) {
     if (CPDF_PageObject* pObj = it->get()) {
-      if (pObj->m_Type == CPDF_PageObject::TEXT) {
+      if (pObj->IsText()) {
         CFX_Matrix matrix;
-        ProcessTextObject(static_cast<CPDF_TextObject*>(pObj), matrix, pObjList,
-                          it);
-      } else if (pObj->m_Type == CPDF_PageObject::FORM) {
+        ProcessTextObject(pObj->AsText(), matrix, pObjList, it);
+      } else if (pObj->IsForm()) {
         CFX_Matrix formMatrix(1, 0, 0, 1, 0, 0);
-        ProcessFormObject(static_cast<CPDF_FormObject*>(pObj), formMatrix);
+        ProcessFormObject(pObj->AsForm(), formMatrix);
       }
     }
   }
   for (int i = 0; i < m_LineObj.GetSize(); i++)
     ProcessTextObject(m_LineObj.GetAt(i));
 
   m_LineObj.RemoveAll();
   CloseTempLine();
 }
 
 void CPDF_TextPage::ProcessFormObject(CPDF_FormObject* pFormObj,
                                       const CFX_Matrix& formMatrix) {
   CPDF_PageObjectList* pObjectList = pFormObj->m_pForm->GetPageObjectList();
   if (pObjectList->empty())
     return;
 
   CFX_Matrix curFormMatrix;
   curFormMatrix.Copy(pFormObj->m_FormMatrix);
   curFormMatrix.Concat(formMatrix);
 
   for (auto it = pObjectList->begin(); it != pObjectList->end(); ++it) {
     if (CPDF_PageObject* pPageObj = it->get()) {
-      if (pPageObj->m_Type == CPDF_PageObject::TEXT) {
-        ProcessTextObject(static_cast<CPDF_TextObject*>(pPageObj),
-                          curFormMatrix, pObjectList, it);
-      } else if (pPageObj->m_Type == CPDF_PageObject::FORM) {
-        ProcessFormObject(static_cast<CPDF_FormObject*>(pPageObj),
-                          curFormMatrix);
+      if (pPageObj->IsText()) {
+        ProcessTextObject(pPageObj->AsText(), curFormMatrix, pObjectList, it);
+      } else if (pPageObj->IsForm()) {
+        ProcessFormObject(pPageObj->AsForm(), curFormMatrix);
       }
     }
   }
 }
 
 int CPDF_TextPage::GetCharWidth(FX_DWORD charCode, CPDF_Font* pFont) const {
   if (charCode == -1) {
     return 0;
   }
   int w = pFont->GetCharWidthF(charCode);
@@ skipping 924 matching lines @@
   return TRUE;
 }
 FX_BOOL CPDF_TextPage::IsSameAsPreTextObject(
     CPDF_TextObject* pTextObj,
     const CPDF_PageObjectList* pObjList,
     CPDF_PageObjectList::const_iterator iter) {
   int i = 0;
   while (i < 5 && iter != pObjList->begin()) {
     --iter;
     CPDF_PageObject* pOtherObj = iter->get();
-    if (pOtherObj == pTextObj || pOtherObj->m_Type != CPDF_PageObject::TEXT)
+    if (pOtherObj == pTextObj || !pOtherObj->IsText())
       continue;
-    if (IsSameTextObject(static_cast<CPDF_TextObject*>(pOtherObj), pTextObj))
+    if (IsSameTextObject(pOtherObj->AsText(), pTextObj))
       return TRUE;
     ++i;
   }
   return FALSE;
 }
 
 FX_BOOL CPDF_TextPage::GenerateCharInfo(FX_WCHAR unicode, PAGECHAR_INFO& info) {
   const PAGECHAR_INFO* preChar;
   if (!m_TempCharList.empty()) {
     preChar = &m_TempCharList.back();
@@ skipping 656 matching lines @@
   if (!m_bIsParsed || index < 0 || index >= m_LinkList.GetSize()) {
     return;
   }
   CPDF_LinkExt* link = NULL;
   link = m_LinkList.GetAt(index);
   if (!link) {
     return;
   }
   m_pTextPage->GetRectArray(link->m_Start, link->m_Count, rects);
 }