core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1709393002: Remove PageObject's m_Type and add As<Type> functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1709393002: Remove PageObject's m_Type and add As<Type> functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index 20f0c39c2573de353f9ebf4c4f166ec77b3405ec..02e3617feb2a83789c5890517d28ed8f09dbb6f2 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -853,7 +853,7 @@ void CPDF_ContentParser::Continue(IFX_Pause* pPause) {

continue;

}

CPDF_Path ClipPath = pObj->m_ClipPath.GetPath(0);

- if (!ClipPath.IsRect() || pObj->m_Type == CPDF_PageObject::SHADING) {

+ if (!ClipPath.IsRect() || pObj->IsShading()) {

continue;

}

CFX_FloatRect old_rect(ClipPath.GetPointX(0), ClipPath.GetPointY(0),