Add wrapBackendTextureAsRenderTarget API

Add wrapBackendTextureAsRenderTarget API

Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
 * wrapBackendTexture - wraps a texture into a GrTexture. Depending on
   flags, this GrTexture can be converted to a GrRenderTarget. Skia
   manages the render target objects it may create to provide a render
   target for the texture. This allows Skia to create stencil buffers
   if needed and manager MSAA resolves.
 * wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
   object cannot be converted to a GrTexture. Skia does not manage
   the render target objects for such a GrRenderTarget, and as such
   cannot attach stencil buffers or perform MSAA resolves on the
   created GrRenderTarget.

Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.

While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.

To address this, a new function is created:
 * wrapBackendTextureAsRenderTarget - wraps a texture into a
   GrRenderTarget. As with wrapBackendTexture, the created render
   target objects are fully managed by Skia. Unlike wrapBackendTexture
   no GrTexture is created, and the created object will never be
   textured from.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709163003

Committed: https://skia.googlesource.com/skia/+/f7b8b8affec91fcfab0d79199e466c16c254fe56

[ericrk, 2016-02-18 21:34:06]

Description was changed from

==========
Add wrapBackendTextureAsRenderTarget API

Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
 * wrapBackendTexture - wraps a texture into a GrTexture. Depending on
   flags, this GrTexture can be converted to a GrRenderTarget. Skia
   manages the render target objects it may create to provide a render
   target for the texture. This allows Skia to create stencil buffers
   if needed and manager MSAA resolves.
 * wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
   object cannot be converted to a GrTexture. Skia does not manage
   the render target objects for such a GrRenderTarget, and as such
   cannot attach stencil buffers or perform MSAA resolves on the
   created GrRenderTarget.

Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.

While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.

To address this, a new function is created:
 * wrapBackendTextureAsRenderTarget - wraps a texture into a
   GrRenderTarget. As with wrapBackendTexture, the created render
   target objects are fully managed by Skia. Unlike wrapBackendTexture
   no GrTexture is created, and the created object will never be
   textured from.

BUG=skia:
==========

to

==========
Add wrapBackendTextureAsRenderTarget API

Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
 * wrapBackendTexture - wraps a texture into a GrTexture. Depending on
   flags, this GrTexture can be converted to a GrRenderTarget. Skia
   manages the render target objects it may create to provide a render
   target for the texture. This allows Skia to create stencil buffers
   if needed and manager MSAA resolves.
 * wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
   object cannot be converted to a GrTexture. Skia does not manage
   the render target objects for such a GrRenderTarget, and as such
   cannot attach stencil buffers or perform MSAA resolves on the
   created GrRenderTarget.

Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.

While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.

To address this, a new function is created:
 * wrapBackendTextureAsRenderTarget - wraps a texture into a
   GrRenderTarget. As with wrapBackendTexture, the created render
   target objects are fully managed by Skia. Unlike wrapBackendTexture
   no GrTexture is created, and the created object will never be
   textured from.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ericrk, 2016-02-19 21:34:07]

ericrk@chromium.org changed reviewers:
+ bsalomon@google.com

[ericrk, 2016-02-19 21:34:08]

Hey Brian, here's my initial take on the API we discussed a couple days ago. Let
me know how this seems.

[bsalomon, 2016-02-22 16:41:01]

Seems like the right direction to me.

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
File include/gpu/GrTextureProvider.h (right):

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
include/gpu/GrTextureProvider.h:111: GrRenderTarget*
wrapBackendTextureAsRenderTarget(const GrBackendTextureDesc& desc,
Can we put this in GrResourceProvider (it's a derived private class of
TexturProvider)? I'd eventually like to hide wrapBackendRT and
wrapBackendTexture there as well and only expose these imports of foreign
textures through SkSurface and SkImage.

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:673: int maxSize = this->caps()->maxTextureSize();
I think this can be checked in the base class

[ericrk, 2016-02-22 21:02:59]

Thanks for the feedback - a few questions.

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
File include/gpu/GrTextureProvider.h (right):

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
include/gpu/GrTextureProvider.h:111: GrRenderTarget*
wrapBackendTextureAsRenderTarget(const GrBackendTextureDesc& desc,
On 2016/02/22 16:41:01, bsalomon wrote:
> Can we put this in GrResourceProvider (it's a derived private class of
> TexturProvider)? I'd eventually like to hide wrapBackendRT and
> wrapBackendTexture there as well and only expose these imports of foreign
> textures through SkSurface and SkImage.

I was planning on calling this directly from Chrome. I'm happy to use an
SkSurface/SkImage wrapper, but I think we currently need to get a GrSurface (not
an SkSurface) so we can call prepareForExternalIO on it... happy to re-work this
though. WDYT?

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:673: int maxSize = this->caps()->maxTextureSize();
On 2016/02/22 16:41:01, bsalomon wrote:
> I think this can be checked in the base class

Was mirroring wrapBackendTexture here - where were you thinking of moving this -
GrGLRenderTarget::CreateWrapped? createRenderTargetObjects?

[bsalomon, 2016-02-23 02:25:27]

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
File include/gpu/GrTextureProvider.h (right):

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
include/gpu/GrTextureProvider.h:111: GrRenderTarget*
wrapBackendTextureAsRenderTarget(const GrBackendTextureDesc& desc,
On 2016/02/22 21:02:59, ericrk wrote:
> On 2016/02/22 16:41:01, bsalomon wrote:
> > Can we put this in GrResourceProvider (it's a derived private class of
> > TexturProvider)? I'd eventually like to hide wrapBackendRT and
> > wrapBackendTexture there as well and only expose these imports of foreign
> > textures through SkSurface and SkImage.
> 
> I was planning on calling this directly from Chrome. I'm happy to use an
> SkSurface/SkImage wrapper, but I think we currently need to get a GrSurface
(not
> an SkSurface) so we can call prepareForExternalIO on it... happy to re-work
this
> though. WDYT?

Gotcha, what if we added a prepareForExternalIO (or similar) to SkSurface?

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:673: int maxSize = this->caps()->maxTextureSize();
On 2016/02/22 21:02:59, ericrk wrote:
> On 2016/02/22 16:41:01, bsalomon wrote:
> > I think this can be checked in the base class
> 
> Was mirroring wrapBackendTexture here - where were you thinking of moving this
-
> GrGLRenderTarget::CreateWrapped? createRenderTargetObjects?

Oh, I see that code now. I was thinking move the size checks from
GrGLGpu::onWrapFoo() to GrGpu::wrapFoo() since we'd want the same checks for all
APIs (GL, Vk, ...).

[ericrk, 2016-02-24 00:01:57]

Patchset #3 (id:40001) has been deleted

[ericrk, 2016-02-24 00:39:53]

Made the suggested edits and added a parallel public function on SkSurface. Let
me know how this looks.

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
File include/gpu/GrTextureProvider.h (right):

https://codereview.chromium.org/1709163003/diff/20001/include/gpu/GrTexturePr...
include/gpu/GrTextureProvider.h:111: GrRenderTarget*
wrapBackendTextureAsRenderTarget(const GrBackendTextureDesc& desc,
On 2016/02/23 02:25:27, bsalomon wrote:
> On 2016/02/22 21:02:59, ericrk wrote:
> > On 2016/02/22 16:41:01, bsalomon wrote:
> > > Can we put this in GrResourceProvider (it's a derived private class of
> > > TexturProvider)? I'd eventually like to hide wrapBackendRT and
> > > wrapBackendTexture there as well and only expose these imports of foreign
> > > textures through SkSurface and SkImage.
> > 
> > I was planning on calling this directly from Chrome. I'm happy to use an
> > SkSurface/SkImage wrapper, but I think we currently need to get a GrSurface
> (not
> > an SkSurface) so we can call prepareForExternalIO on it... happy to re-work
> this
> > though. WDYT?
> 
> Gotcha, what if we added a prepareForExternalIO (or similar) to SkSurface?

Added this function.

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1709163003/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:673: int maxSize = this->caps()->maxTextureSize();
On 2016/02/23 02:25:27, bsalomon wrote:
> On 2016/02/22 21:02:59, ericrk wrote:
> > On 2016/02/22 16:41:01, bsalomon wrote:
> > > I think this can be checked in the base class
> > 
> > Was mirroring wrapBackendTexture here - where were you thinking of moving
this
> -
> > GrGLRenderTarget::CreateWrapped? createRenderTargetObjects?
> 
> Oh, I see that code now. I was thinking move the size checks from
> GrGLGpu::onWrapFoo() to GrGpu::wrapFoo() since we'd want the same checks for
all
> APIs (GL, Vk, ...).

Good point - moved.

[bsalomon, 2016-02-24 18:22:02]

lgtm with some minor nits

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/GrResourceProvi...
File src/gpu/GrResourceProvider.cpp (right):

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/GrResourceProvi...
src/gpu/GrResourceProvider.cpp:233: return nullptr;
four space indent

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:718:
////////////////////////////////////////////////////////////////////////////////
\n

[ericrk, 2016-02-24 19:59:09]

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/GrResourceProvi...
File src/gpu/GrResourceProvider.cpp (right):

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/GrResourceProvi...
src/gpu/GrResourceProvider.cpp:233: return nullptr;
On 2016/02/24 18:22:02, bsalomon wrote:
> four space indent

Done.

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1709163003/diff/60001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:718:
////////////////////////////////////////////////////////////////////////////////
On 2016/02/24 18:22:02, bsalomon wrote:
> \n

Done.

[ericrk, 2016-02-24 20:02:55]

Patchset #5 (id:100001) has been deleted

[ericrk, 2016-02-24 20:04:20]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-02-24 20:04:20]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1709163003/#ps120001
(title: "extra line")

[commit-bot: I haz the power, 2016-02-24 20:04:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709163003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709163003/120001

[commit-bot: I haz the power, 2016-02-24 20:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 20:05:46]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[ericrk, 2016-02-24 21:09:55]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-02-24 21:09:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1709163003/#ps140001
(title: "fix test")

[commit-bot: I haz the power, 2016-02-24 21:10:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709163003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709163003/140001

[commit-bot: I haz the power, 2016-02-24 22:49:55]

Description was changed from

==========
Add wrapBackendTextureAsRenderTarget API

Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
 * wrapBackendTexture - wraps a texture into a GrTexture. Depending on
   flags, this GrTexture can be converted to a GrRenderTarget. Skia
   manages the render target objects it may create to provide a render
   target for the texture. This allows Skia to create stencil buffers
   if needed and manager MSAA resolves.
 * wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
   object cannot be converted to a GrTexture. Skia does not manage
   the render target objects for such a GrRenderTarget, and as such
   cannot attach stencil buffers or perform MSAA resolves on the
   created GrRenderTarget.

Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.

While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.

To address this, a new function is created:
 * wrapBackendTextureAsRenderTarget - wraps a texture into a
   GrRenderTarget. As with wrapBackendTexture, the created render
   target objects are fully managed by Skia. Unlike wrapBackendTexture
   no GrTexture is created, and the created object will never be
   textured from.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add wrapBackendTextureAsRenderTarget API

Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
 * wrapBackendTexture - wraps a texture into a GrTexture. Depending on
   flags, this GrTexture can be converted to a GrRenderTarget. Skia
   manages the render target objects it may create to provide a render
   target for the texture. This allows Skia to create stencil buffers
   if needed and manager MSAA resolves.
 * wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
   object cannot be converted to a GrTexture. Skia does not manage
   the render target objects for such a GrRenderTarget, and as such
   cannot attach stencil buffers or perform MSAA resolves on the
   created GrRenderTarget.

Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.

While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.

To address this, a new function is created:
 * wrapBackendTextureAsRenderTarget - wraps a texture into a
   GrRenderTarget. As with wrapBackendTexture, the created render
   target objects are fully managed by Skia. Unlike wrapBackendTexture
   no GrTexture is created, and the created object will never be
   textured from.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f7b8b8affec91fcfab0d79199e466c16c254fe56
==========

[commit-bot: I haz the power, 2016-02-24 22:49:56]

Committed patchset #6 (id:140001) as
https://skia.googlesource.com/skia/+/f7b8b8affec91fcfab0d79199e466c16c254fe56