Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1708853002: MIPS: [turbofan] Add TruncateFloat32ToUint32 operator to Turbofan. (Closed)

Created:
4 years, 10 months ago by akos.palfi.imgtec
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Add TruncateFloat32ToUint32 operator to Turbofan. Port 2166bd8ce51f83693fa88f590b82d24a1856e0e7 BUG= Committed: https://crrev.com/57b983ec5b723eb0726e3537119921a3059ddff8 Cr-Commit-Position: refs/heads/master@{#34112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
akos.palfi.imgtec
PTAL.
4 years, 10 months ago (2016-02-17 22:54:00 UTC) #2
Ilija.Pavlovic1
Missing the test for macro Trunc_uw_s in test-assembler-mips.cc and test-assembler-mips64.cc
4 years, 10 months ago (2016-02-18 10:29:15 UTC) #4
balazs.kilvady
On 2016/02/18 10:29:15, Ilija.Pavlovic1 wrote: > Missing the test for macro Trunc_uw_s in test-assembler-mips.cc and ...
4 years, 10 months ago (2016-02-18 12:00:16 UTC) #5
balazs.kilvady
On 2016/02/18 12:00:16, balazs.kilvady wrote: > On 2016/02/18 10:29:15, Ilija.Pavlovic1 wrote: > > Missing the ...
4 years, 10 months ago (2016-02-18 12:02:06 UTC) #6
Ilija.Pavlovic1
lgtm OK. I agree.
4 years, 10 months ago (2016-02-18 12:26:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708853002/1
4 years, 10 months ago (2016-02-18 12:31:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 12:48:47 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 12:49:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57b983ec5b723eb0726e3537119921a3059ddff8
Cr-Commit-Position: refs/heads/master@{#34112}

Powered by Google App Engine
This is Rietveld 408576698