|
|
Created:
4 years, 10 months ago by rune Modified:
4 years, 10 months ago CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland: Propagate inherited properties into slotted elements on recalc.
When we reach a <slot> element during recalc, we need to trigger recalc
of elements distributed to that slot for inheritance. This is similar
to what is done for InsertionPoint. I have however not found a case
where we need a bigger cannon than LocalStyleChange on the distributed
elements.
Made a few override methods final, expecting no inheritance of
HTMLSlotElement.
R=kochi@chromium.org,hayato@chromium.org
BUG=587797
Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c
Cr-Commit-Position: refs/heads/master@{#376406}
Committed: https://crrev.com/8bb756774ac71289c4b1d6cd3be1d728df8f0aa4
Cr-Commit-Position: refs/heads/master@{#376461}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebased #Patch Set 3 : Fixed non-oilpan build #
Messages
Total messages: 27 (12 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 ========== to ========== Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1718433002/ by ksakamoto@chromium.org. The reason for reverting is: Broke non-oilpan build. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi....
Message was sent while issue was closed.
https://codereview.chromium.org/1708213002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/html/HTMLSlotElement.cpp (right): https://codereview.chromium.org/1708213002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/html/HTMLSlotElement.cpp:210: for (Node* node : m_distributedNodes) Hmm, this should have been RefPtrWillBeRawPtr<Node> instead of Node*.
Message was sent while issue was closed.
Description was changed from ========== Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ========== to ========== Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ==========
Description was changed from ========== Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ========== to ========== Reland: Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ==========
The CQ bit was checked by rune@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org Link to the patchset: https://codereview.chromium.org/1708213002/#ps40001 (title: "Fixed non-oilpan build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/40001
Message was sent while issue was closed.
Description was changed from ========== Reland: Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ========== to ========== Reland: Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reland: Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} ========== to ========== Reland: Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} Committed: https://crrev.com/8bb756774ac71289c4b1d6cd3be1d728df8f0aa4 Cr-Commit-Position: refs/heads/master@{#376461} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8bb756774ac71289c4b1d6cd3be1d728df8f0aa4 Cr-Commit-Position: refs/heads/master@{#376461} |