Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1708213002: Propagate inherited properties into slotted elements on recalc. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
hayato, kochi
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Propagate inherited properties into slotted elements on recalc. When we reach a <slot> element during recalc, we need to trigger recalc of elements distributed to that slot for inheritance. This is similar to what is done for InsertionPoint. I have however not found a case where we need a bigger cannon than LocalStyleChange on the distributed elements. Made a few override methods final, expecting no inheritance of HTMLSlotElement. R=kochi@chromium.org,hayato@chromium.org BUG=587797 Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406} Committed: https://crrev.com/8bb756774ac71289c4b1d6cd3be1d728df8f0aa4 Cr-Commit-Position: refs/heads/master@{#376461}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : Fixed non-oilpan build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/inherit-into-slotted.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/inherit-into-slotted-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
rune
ptal
4 years, 10 months ago (2016-02-18 14:33:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/1
4 years, 10 months ago (2016-02-18 14:34:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 16:05:13 UTC) #5
kochi
lgtm
4 years, 10 months ago (2016-02-19 02:29:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/1
4 years, 10 months ago (2016-02-19 06:23:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 06:29:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c Cr-Commit-Position: refs/heads/master@{#376406}
4 years, 10 months ago (2016-02-19 06:31:14 UTC) #11
Kunihiko Sakamoto
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1718433002/ by ksakamoto@chromium.org. ...
4 years, 10 months ago (2016-02-19 06:43:50 UTC) #12
kochi
https://codereview.chromium.org/1708213002/diff/1/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp File third_party/WebKit/Source/core/html/HTMLSlotElement.cpp (right): https://codereview.chromium.org/1708213002/diff/1/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp#newcode210 third_party/WebKit/Source/core/html/HTMLSlotElement.cpp:210: for (Node* node : m_distributedNodes) Hmm, this should have ...
4 years, 10 months ago (2016-02-19 08:04:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/40001
4 years, 10 months ago (2016-02-19 08:30:41 UTC) #18
kochi
lgtm
4 years, 10 months ago (2016-02-19 08:36:20 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/25726)
4 years, 10 months ago (2016-02-19 12:24:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708213002/40001
4 years, 10 months ago (2016-02-19 13:44:35 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-19 16:58:43 UTC) #25
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 17:00:57 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8bb756774ac71289c4b1d6cd3be1d728df8f0aa4
Cr-Commit-Position: refs/heads/master@{#376461}

Powered by Google App Engine
This is Rietveld 408576698