Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 1718433002: Revert of Propagate inherited properties into slotted elements on recalc. (Closed)

Created:
4 years, 10 months ago by Kunihiko Sakamoto
Modified:
4 years, 10 months ago
Reviewers:
hayato, kochi, rune
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Propagate inherited properties into slotted elements on recalc. (patchset #1 id:1 of https://codereview.chromium.org/1708213002/ ) Reason for revert: Broke non-oilpan build. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oilpan%20Builder/builds/289/steps/compile/logs/stdio Original issue's description: > Propagate inherited properties into slotted elements on recalc. > > When we reach a <slot> element during recalc, we need to trigger recalc > of elements distributed to that slot for inheritance. This is similar > to what is done for InsertionPoint. I have however not found a case > where we need a bigger cannon than LocalStyleChange on the distributed > elements. > > Made a few override methods final, expecting no inheritance of > HTMLSlotElement. > > R=kochi@chromium.org,hayato@chromium.org > BUG=587797 > > Committed: https://crrev.com/e6491c6e66c3393363402f04f625959e29ba236c > Cr-Commit-Position: refs/heads/master@{#376406} TBR=hayato@chromium.org,kochi@chromium.org,rune@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587797 Committed: https://crrev.com/6628852ff038b57385d47d8542bf59d32b98f035 Cr-Commit-Position: refs/heads/master@{#376408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -45 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/shadow/inherit-into-slotted.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/inherit-into-slotted-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kunihiko Sakamoto
Created Revert of Propagate inherited properties into slotted elements on recalc.
4 years, 10 months ago (2016-02-19 06:43:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718433002/1
4 years, 10 months ago (2016-02-19 06:44:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 06:45:40 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 06:47:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6628852ff038b57385d47d8542bf59d32b98f035
Cr-Commit-Position: refs/heads/master@{#376408}

Powered by Google App Engine
This is Rietveld 408576698