third_party/WebKit/Source/core/html/HTMLSlotElement.h - Issue 1708213002: Propagate inherited properties into slotted elements on recalc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 1708213002: Propagate inherited properties into slotted elements on recalc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed non-oilpan build Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/inherit-into-slotted-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

index b72bd375cebd3e7a2a48eef6b81af0c5938b55bc..991d2fd3ec1fc958693ba084fe1aec77574ef31b 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

@@ -63,19 +63,20 @@ public:

void updateDistributedNodesWithFallback();

void didUpdateDistribution();

- void attach(const AttachContext& = AttachContext()) override;

- void detach(const AttachContext& = AttachContext()) override;

+ void attach(const AttachContext& = AttachContext()) final;

+ void detach(const AttachContext& = AttachContext()) final;

- void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason = ModifiedDirectly) override;

+ void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason = ModifiedDirectly) final;

DECLARE_VIRTUAL_TRACE();

private:

HTMLSlotElement(Document&);

- void childrenChanged(const ChildrenChange&) override;

- InsertionNotificationRequest insertedInto(ContainerNode*) override;

- void removedFrom(ContainerNode*) override;

+ void childrenChanged(const ChildrenChange&) final;

+ InsertionNotificationRequest insertedInto(ContainerNode*) final;

+ void removedFrom(ContainerNode*) final;

+ void willRecalcStyle(StyleRecalcChange) final;

void dispatchSlotChangeEvent();