Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 1707773002: Revert of Remove HostDesktopType from AppLaunchParams (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
benwells, sky
CC:
chromium-reviews, tapted, sadrul, Matt Giuca, extensions-reviews_chromium.org, tfarina, chromium-apps-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-15
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove HostDesktopType from AppLaunchParams (patchset #2 id:20001 of https://codereview.chromium.org/1685883003/ ) Reason for revert: The two AppLaunchParams ctors args are the same except for the HostDesktopType (which they don't use), but the existence of that argument was being used as a bool to choose a constructor which did different things. I think this likely caused https://code.google.com/p/chromium/issues/detail?id=587387 and https://code.google.com/p/chromium/issues/detail?id=586862 . Original issue's description: > Remove HostDesktopType from AppLaunchParams > > R=sky@chromium.org, benwells@chromium.org > BUG=558054 > > Committed: https://crrev.com/99230da5e39ce56f28f05a515941fae53ba5eded > Cr-Commit-Position: refs/heads/master@{#374814} TBR=benwells@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=558054, 587387, 586862 Committed: https://crrev.com/99dd35690fb24248158a61de0235e292426f31fd Cr-Commit-Position: refs/heads/master@{#375945}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : required git cl format #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -13 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/first_run/first_run_controller.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_common.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.h View 1 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
scottmg
Created Revert of Remove HostDesktopType from AppLaunchParams
4 years, 10 months ago (2016-02-17 17:34:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707773002/1
4 years, 10 months ago (2016-02-17 17:35:03 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/132007) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-17 17:37:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707773002/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707773002/290001
4 years, 10 months ago (2016-02-17 17:57:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/159904) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-17 18:09:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707773002/310001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707773002/310001
4 years, 10 months ago (2016-02-17 18:27:57 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:310001)
4 years, 10 months ago (2016-02-17 19:14:47 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 19:16:25 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/99dd35690fb24248158a61de0235e292426f31fd
Cr-Commit-Position: refs/heads/master@{#375945}

Powered by Google App Engine
This is Rietveld 408576698