Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/ui/extensions/app_launch_params.cc

Issue 1707773002: Revert of Remove HostDesktopType from AppLaunchParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-15
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/extensions/app_launch_params.h" 5 #include "chrome/browser/ui/extensions/app_launch_params.h"
6 6
7 #include "chrome/browser/extensions/launch_util.h" 7 #include "chrome/browser/extensions/launch_util.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "extensions/browser/extension_prefs.h" 9 #include "extensions/browser/extension_prefs.h"
10 #include "extensions/common/constants.h" 10 #include "extensions/common/constants.h"
11 #include "extensions/common/extension.h" 11 #include "extensions/common/extension.h"
12 #include "ui/base/window_open_disposition.h" 12 #include "ui/base/window_open_disposition.h"
13 13
14 using extensions::ExtensionPrefs; 14 using extensions::ExtensionPrefs;
15 15
16 AppLaunchParams::AppLaunchParams(Profile* profile, 16 AppLaunchParams::AppLaunchParams(Profile* profile,
17 const extensions::Extension* extension, 17 const extensions::Extension* extension,
18 extensions::LaunchContainer container, 18 extensions::LaunchContainer container,
19 WindowOpenDisposition disposition, 19 WindowOpenDisposition disposition,
20 extensions::AppLaunchSource source) 20 extensions::AppLaunchSource source)
21 : profile(profile), 21 : profile(profile),
22 extension_id(extension ? extension->id() : std::string()), 22 extension_id(extension ? extension->id() : std::string()),
23 container(container), 23 container(container),
24 disposition(disposition), 24 disposition(disposition),
25 desktop_type(chrome::GetActiveDesktop()),
25 override_url(), 26 override_url(),
26 override_bounds(), 27 override_bounds(),
27 command_line(base::CommandLine::NO_PROGRAM), 28 command_line(base::CommandLine::NO_PROGRAM),
28 source(source) { 29 source(source) {
29 } 30 }
30 31
31 AppLaunchParams::AppLaunchParams(Profile* profile, 32 AppLaunchParams::AppLaunchParams(Profile* profile,
32 const extensions::Extension* extension, 33 const extensions::Extension* extension,
34 WindowOpenDisposition disposition,
35 extensions::AppLaunchSource source)
36 : profile(profile),
37 extension_id(extension ? extension->id() : std::string()),
38 container(extensions::LAUNCH_CONTAINER_NONE),
39 disposition(disposition),
40 desktop_type(chrome::GetActiveDesktop()),
41 override_url(),
42 override_bounds(),
43 command_line(base::CommandLine::NO_PROGRAM),
44 source(source) {
45 // Look up the app preference to find out the right launch container. Default
46 // is to launch as a regular tab.
47 container =
48 extensions::GetLaunchContainer(ExtensionPrefs::Get(profile), extension);
49 }
50
51 AppLaunchParams::AppLaunchParams(Profile* profile,
52 const extensions::Extension* extension,
33 WindowOpenDisposition raw_disposition, 53 WindowOpenDisposition raw_disposition,
54 chrome::HostDesktopType desktop_type,
34 extensions::AppLaunchSource source) 55 extensions::AppLaunchSource source)
35 : profile(profile), 56 : profile(profile),
36 extension_id(extension ? extension->id() : std::string()), 57 extension_id(extension ? extension->id() : std::string()),
37 container(extensions::LAUNCH_CONTAINER_NONE), 58 container(extensions::LAUNCH_CONTAINER_NONE),
59 desktop_type(desktop_type),
38 override_url(), 60 override_url(),
39 override_bounds(), 61 override_bounds(),
40 command_line(base::CommandLine::NO_PROGRAM), 62 command_line(base::CommandLine::NO_PROGRAM),
41 source(source) { 63 source(source) {
42 if (raw_disposition == NEW_FOREGROUND_TAB || 64 if (raw_disposition == NEW_FOREGROUND_TAB ||
43 raw_disposition == NEW_BACKGROUND_TAB) { 65 raw_disposition == NEW_BACKGROUND_TAB) {
44 container = extensions::LAUNCH_CONTAINER_TAB; 66 container = extensions::LAUNCH_CONTAINER_TAB;
45 disposition = raw_disposition; 67 disposition = raw_disposition;
46 } else if (raw_disposition == NEW_WINDOW) { 68 } else if (raw_disposition == NEW_WINDOW) {
47 container = extensions::LAUNCH_CONTAINER_WINDOW; 69 container = extensions::LAUNCH_CONTAINER_WINDOW;
48 disposition = raw_disposition; 70 disposition = raw_disposition;
49 } else { 71 } else {
50 // Look at preference to find the right launch container. If no preference 72 // Look at preference to find the right launch container. If no preference
51 // is set, launch as a regular tab. 73 // is set, launch as a regular tab.
52 container = 74 container =
53 extensions::GetLaunchContainer(ExtensionPrefs::Get(profile), extension); 75 extensions::GetLaunchContainer(ExtensionPrefs::Get(profile), extension);
54 disposition = NEW_FOREGROUND_TAB; 76 disposition = NEW_FOREGROUND_TAB;
55 } 77 }
56 } 78 }
57 79
58 AppLaunchParams::~AppLaunchParams() { 80 AppLaunchParams::~AppLaunchParams() {
59 } 81 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/extensions/app_launch_params.h ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698