chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc - Issue 1707773002: Revert of Remove HostDesktopType from AppLaunchParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

Issue 1707773002: Revert of Remove HostDesktopType from AppLaunchParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-15

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

diff --git a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

index 45b8a34891e5b624269ea25ce555e91c0d1fa08f..178a9298b11b110fec5904a232b661d70f7f968f 100644

--- a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

+++ b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

@@ -40,12 +40,14 @@ void ChromeNewWindowDelegateChromeos::OpenFileManager() {

const extensions::Extension* const extension =

service->GetInstalledExtension(kFileManagerAppId);

OpenApplication(AppLaunchParams(profile, extension, CURRENT_TAB,

+ chrome::HOST_DESKTOP_TYPE_ASH,

extensions::SOURCE_KEYBOARD));

}

void ChromeNewWindowDelegateChromeos::OpenGetHelp() {

Profile* const profile = ProfileManager::GetActiveUserProfile();

- chrome::ShowHelpForProfile(profile, chrome::HELP_SOURCE_KEYBOARD);

+ chrome::ShowHelpForProfile(profile, chrome::HOST_DESKTOP_TYPE_ASH,

+ chrome::HELP_SOURCE_KEYBOARD);

}

void ChromeNewWindowDelegateChromeos::OpenCrosh() {