chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc - Issue 1707773002: Revert of Remove HostDesktopType from AppLaunchParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

Issue 1707773002: Revert of Remove HostDesktopType from AppLaunchParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-15

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

index 61adb3f10e146a61ca62f58a96d496261c572d9d..dd9c48e7d535ef4308e8b2feebaf4d713aa76fe7 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

@@ -780,9 +780,9 @@ void ChromeLauncherController::LaunchApp(const std::string& app_id,

}

// The app will be created for the currently active profile.

- AppLaunchParams params(profile_, extension,

- ui::DispositionFromEventFlags(event_flags),

- extensions::SOURCE_APP_LAUNCHER);

+ AppLaunchParams params(

+ profile_, extension, ui::DispositionFromEventFlags(event_flags),

+ chrome::HOST_DESKTOP_TYPE_ASH, extensions::SOURCE_APP_LAUNCHER);

if (source != ash::LAUNCH_FROM_UNKNOWN &&

app_id == extensions::kWebStoreAppId) {

// Get the corresponding source string.