Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: Source/core/dom/PopStateEvent.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reverted to version that expects GetHiddenValue to not return an empty Handle for undefined Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/PopStateEvent.h
diff --git a/Source/core/dom/PopStateEvent.h b/Source/core/dom/PopStateEvent.h
index 1c59d0f302dd0686f8adb64c788c2cfc4dbecb15..dca5c416df8dec21c47972209b51ce902bb326a6 100644
--- a/Source/core/dom/PopStateEvent.h
+++ b/Source/core/dom/PopStateEvent.h
@@ -27,16 +27,11 @@
#ifndef PopStateEvent_h
#define PopStateEvent_h
-#include "bindings/v8/ScriptValue.h"
#include "core/dom/Event.h"
namespace WebCore {
-struct PopStateEventInit : public EventInit {
haraken 2013/06/27 04:50:27 Ditto.
jww 2013/06/27 17:44:42 See my comments on CustomEventInit.
- PopStateEventInit();
-
- ScriptValue state;
-};
+typedef EventInit PopStateEventInit;
haraken 2013/06/27 04:50:27 Ditto.
jww 2013/06/27 17:44:42 See my comments on CustomEventInit.
class History;
class SerializedScriptValue;
@@ -49,7 +44,6 @@ public:
static PassRefPtr<PopStateEvent> create(const AtomicString&, const PopStateEventInit&);
PassRefPtr<SerializedScriptValue> serializedState() const { return m_serializedState; }
- const ScriptValue& state() const { return m_state; }
History* history() const { return m_history.get(); }
virtual const AtomicString& interfaceName() const;
@@ -59,7 +53,6 @@ private:
PopStateEvent(const AtomicString&, const PopStateEventInit&);
explicit PopStateEvent(PassRefPtr<SerializedScriptValue>, PassRefPtr<History>);
- ScriptValue m_state;
RefPtr<SerializedScriptValue> m_serializedState;
RefPtr<History> m_history;
};

Powered by Google App Engine
This is Rietveld 408576698