Source/core/dom/PopStateEvent.cpp - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/PopStateEvent.cpp

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reverted to version that expects GetHiddenValue to not return an empty Handle for undefined Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/PopStateEvent.cpp

diff --git a/Source/core/dom/PopStateEvent.cpp b/Source/core/dom/PopStateEvent.cpp

index 072d28ba177377fa4f55318709e6094a4e0b8980..78456c830c6a551a5fe4f125c7270b30f676243b 100644

--- a/Source/core/dom/PopStateEvent.cpp

+++ b/Source/core/dom/PopStateEvent.cpp

@@ -33,10 +33,6 @@

namespace WebCore {

-PopStateEventInit::PopStateEventInit()

haraken 2013/06/27 04:50:27 Ditto.

jww 2013/06/27 17:44:42 See my comments on CustomEventInit.

PopStateEvent::PopStateEvent()

: Event(eventNames().popstateEvent, false, true)

, m_serializedState(0)

@@ -47,7 +43,6 @@ PopStateEvent::PopStateEvent()

PopStateEvent::PopStateEvent(const AtomicString& type, const PopStateEventInit& initializer)

: Event(type, initializer)

- , m_state(initializer.state)

, m_serializedState(0)

, m_history(0)

{

« Source/core/dom/PopStateEvent.h ('K') | « Source/core/dom/PopStateEvent.h ('k') | no next file » | no next file with comments »