Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: Source/core/dom/CustomEvent.cpp

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reverted to version that expects GetHiddenValue to not return an empty Handle for undefined Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/CustomEvent.cpp
diff --git a/Source/core/dom/CustomEvent.cpp b/Source/core/dom/CustomEvent.cpp
index c7e67b3eb97a9e9f44106767f0457f359c2fa9ab..bad25d2fe2c0055d8a6d4d28431ff7fc8900c39c 100644
--- a/Source/core/dom/CustomEvent.cpp
+++ b/Source/core/dom/CustomEvent.cpp
@@ -30,10 +30,6 @@
namespace WebCore {
-CustomEventInit::CustomEventInit()
-{
-}
haraken 2013/06/27 04:50:27 Ditto. We might not want to remove this.
jww 2013/06/27 17:44:42 Same response applies as to the CurrentEventInit r
-
CustomEvent::CustomEvent()
{
ScriptWrappable::init(this);
@@ -41,7 +37,6 @@ CustomEvent::CustomEvent()
CustomEvent::CustomEvent(const AtomicString& type, const CustomEventInit& initializer)
: Event(type, initializer)
- , m_detail(initializer.detail)
{
ScriptWrappable::init(this);
}
@@ -50,20 +45,8 @@ CustomEvent::~CustomEvent()
{
}
-void CustomEvent::initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& detail)
-{
- ASSERT(!m_serializedScriptValue.get());
- if (dispatched())
- return;
-
- initEvent(type, canBubble, cancelable);
-
- m_detail = detail;
-}
-
void CustomEvent::initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<SerializedScriptValue> serializedScriptValue)
{
- ASSERT(m_detail.hasNoValue());
if (dispatched())
return;

Powered by Google App Engine
This is Rietveld 408576698