Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: Source/core/dom/PopStateEvent.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reverted to version that expects GetHiddenValue to not return an empty Handle for undefined Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 * 24 *
25 */ 25 */
26 26
27 #ifndef PopStateEvent_h 27 #ifndef PopStateEvent_h
28 #define PopStateEvent_h 28 #define PopStateEvent_h
29 29
30 #include "bindings/v8/ScriptValue.h"
31 #include "core/dom/Event.h" 30 #include "core/dom/Event.h"
32 31
33 namespace WebCore { 32 namespace WebCore {
34 33
35 struct PopStateEventInit : public EventInit { 34 typedef EventInit PopStateEventInit;
haraken 2013/06/27 04:50:27 Ditto.
jww 2013/06/27 17:44:42 See my comments on CustomEventInit.
haraken 2013/06/27 04:50:27 Ditto.
jww 2013/06/27 17:44:42 See my comments on CustomEventInit.
36 PopStateEventInit();
37
38 ScriptValue state;
39 };
40 35
41 class History; 36 class History;
42 class SerializedScriptValue; 37 class SerializedScriptValue;
43 38
44 class PopStateEvent : public Event { 39 class PopStateEvent : public Event {
45 public: 40 public:
46 virtual ~PopStateEvent(); 41 virtual ~PopStateEvent();
47 static PassRefPtr<PopStateEvent> create(); 42 static PassRefPtr<PopStateEvent> create();
48 static PassRefPtr<PopStateEvent> create(PassRefPtr<SerializedScriptValue>, P assRefPtr<History>); 43 static PassRefPtr<PopStateEvent> create(PassRefPtr<SerializedScriptValue>, P assRefPtr<History>);
49 static PassRefPtr<PopStateEvent> create(const AtomicString&, const PopStateE ventInit&); 44 static PassRefPtr<PopStateEvent> create(const AtomicString&, const PopStateE ventInit&);
50 45
51 PassRefPtr<SerializedScriptValue> serializedState() const { return m_seriali zedState; } 46 PassRefPtr<SerializedScriptValue> serializedState() const { return m_seriali zedState; }
52 const ScriptValue& state() const { return m_state; }
53 History* history() const { return m_history.get(); } 47 History* history() const { return m_history.get(); }
54 48
55 virtual const AtomicString& interfaceName() const; 49 virtual const AtomicString& interfaceName() const;
56 50
57 private: 51 private:
58 PopStateEvent(); 52 PopStateEvent();
59 PopStateEvent(const AtomicString&, const PopStateEventInit&); 53 PopStateEvent(const AtomicString&, const PopStateEventInit&);
60 explicit PopStateEvent(PassRefPtr<SerializedScriptValue>, PassRefPtr<History >); 54 explicit PopStateEvent(PassRefPtr<SerializedScriptValue>, PassRefPtr<History >);
61 55
62 ScriptValue m_state;
63 RefPtr<SerializedScriptValue> m_serializedState; 56 RefPtr<SerializedScriptValue> m_serializedState;
64 RefPtr<History> m_history; 57 RefPtr<History> m_history;
65 }; 58 };
66 59
67 } // namespace WebCore 60 } // namespace WebCore
68 61
69 #endif // PopStateEvent_h 62 #endif // PopStateEvent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698