Remove leak of objects between isolated worlds on custom events.

Source/core/dom/CustomEvent.h

Index: Source/core/dom/CustomEvent.h
diff --git a/Source/core/dom/CustomEvent.h b/Source/core/dom/CustomEvent.h
index 6afc0ae12a2e08192039934f61fca4e48a8d4e3a..be0f7171071595acb8e251505cbbcf6c6b7fd6ea 100644
--- a/Source/core/dom/CustomEvent.h
+++ b/Source/core/dom/CustomEvent.h
@@ -32,11 +32,7 @@
 
 namespace WebCore {
 
-struct CustomEventInit : public EventInit {
-    CustomEventInit();
-
-    ScriptValue detail;
-};
+typedef EventInit CustomEventInit;

[haraken, 2013/06/27 04:50:27]

Why do you need to make this change? Given the spec has CustomEventInit, we
might want to keep it in implementation as well.

[adamk, 2013/06/27 17:11:45]

I asked for this change; I just see a typedef as clearer than a subclass that's
identical to its superclass. Yes, it's in the spec, and it indeed appears in the
IDL file, but that doesn't mean it has to appear in C++ as a struct declaration.

[jww, 2013/06/27 17:44:42]

adamk's response is what I was going to say as well. To me, it seems like we
still have a CustomEventInit type as per the spec; it just happens to be
identical to the EventInit type.

 
 class CustomEvent : public Event {
 public:
@@ -52,19 +48,16 @@ public:
         return adoptRef(new CustomEvent(type, initializer));
     }
 
-    void initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& detail);
     void initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<SerializedScriptValue>);
 
     virtual const AtomicString& interfaceName() const;
 
-    const ScriptValue& detail() const { return m_detail; }
     PassRefPtr<SerializedScriptValue> serializedScriptValue() { return m_serializedScriptValue; }
 
 private:
     CustomEvent();
     CustomEvent(const AtomicString& type, const CustomEventInit& initializer);
 
-    ScriptValue m_detail;
     RefPtr<SerializedScriptValue> m_serializedScriptValue;
 };