Remove leak of objects between isolated worlds on custom events.

Source/core/dom/CustomEvent.h

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 14 matching lines @@
 
 #ifndef CustomEvent_h
 #define CustomEvent_h
 
 #include "bindings/v8/ScriptValue.h"
 #include "bindings/v8/SerializedScriptValue.h"
 #include "core/dom/Event.h"
 
 namespace WebCore {
 
-struct CustomEventInit : public EventInit {
-    CustomEventInit();
-
-    ScriptValue detail;
-};
+typedef EventInit CustomEventInit;

[haraken, 2013/06/27 04:50:27]

Why do you need to make this change? Given the spec has CustomEventInit, we
might want to keep it in implementation as well.

[adamk, 2013/06/27 17:11:45]

I asked for this change; I just see a typedef as clearer than a subclass that's
identical to its superclass. Yes, it's in the spec, and it indeed appears in the
IDL file, but that doesn't mean it has to appear in C++ as a struct declaration.

[jww, 2013/06/27 17:44:42]

adamk's response is what I was going to say as well. To me, it seems like we
still have a CustomEventInit type as per the spec; it just happens to be
identical to the EventInit type.

 
 class CustomEvent : public Event {
 public:
     virtual ~CustomEvent();
 
     static PassRefPtr<CustomEvent> create()
     {
         return adoptRef(new CustomEvent);
     }
 
     static PassRefPtr<CustomEvent> create(const AtomicString& type, const CustomEventInit& initializer)
     {
         return adoptRef(new CustomEvent(type, initializer));
     }
 
-    void initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& detail);
     void initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<SerializedScriptValue>);
 
     virtual const AtomicString& interfaceName() const;
 
-    const ScriptValue& detail() const { return m_detail; }
     PassRefPtr<SerializedScriptValue> serializedScriptValue() { return m_serializedScriptValue; }
 
 private:
     CustomEvent();
     CustomEvent(const AtomicString& type, const CustomEventInit& initializer);
 
-    ScriptValue m_detail;
     RefPtr<SerializedScriptValue> m_serializedScriptValue;
 };
 
 } // namespace WebCore
 
 #endif // CustomEvent_h