Source/bindings/v8/custom/V8PopStateEventCustom.cpp - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8PopStateEventCustom.cpp

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reverted to version that expects GetHiddenValue to not return an empty Handle for undefined Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8MessageEventCustom.cpp ('K') | « Source/bindings/v8/custom/V8MessageEventCustom.cpp ('k') | Source/core/dom/CustomEvent.h » ('j') | Source/core/dom/CustomEvent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8PopStateEventCustom.cpp

diff --git a/Source/bindings/v8/custom/V8PopStateEventCustom.cpp b/Source/bindings/v8/custom/V8PopStateEventCustom.cpp

index 43ac29ac220fb1fe3a44680d28495d7987644381..b50b33c7838e0f0be1e2102cfa3ea7a84a53a409 100644

--- a/Source/bindings/v8/custom/V8PopStateEventCustom.cpp

+++ b/Source/bindings/v8/custom/V8PopStateEventCustom.cpp

@@ -56,11 +56,6 @@ void V8PopStateEvent::stateAttrGetterCustom(v8::Local<v8::String> name, const v8

}

PopStateEvent* event = V8PopStateEvent::toNative(info.Holder());

- if (!event->state().hasNoValue()) {

- v8SetReturnValue(info, cacheState(info.Holder(), event->state().v8Value()));

- return;

- }

History* history = event->history();

if (!history || !event->serializedState()) {

v8SetReturnValue(info, cacheState(info.Holder(), v8Null(info.GetIsolate())));