Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705713002: [runtime] Replace hidden_string with a 0-hash-code private symbol (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Replace hidden_string with a 0-hash-code private symbol BUG= Committed: https://crrev.com/9eb4929502795b40324bd5ffda2840ec37793acd Cr-Commit-Position: refs/heads/master@{#34070}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -61 lines) Patch
M src/heap-symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 chunks +8 lines, -11 lines 1 comment Download
M src/ic/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/objects.cc View 1 10 chunks +17 lines, -20 lines 0 comments Download
M src/objects-debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-17 10:22:18 UTC) #2
ulan
lgtm https://codereview.chromium.org/1705713002/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1705713002/diff/40001/src/heap/heap.cc#newcode2704 src/heap/heap.cc:2704: ->set_hash_field(Name::kIsNotArrayIndexMask); Oh well
4 years, 10 months ago (2016-02-17 10:45:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705713002/40001
4 years, 10 months ago (2016-02-17 10:46:50 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 11:10:14 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 11:10:50 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9eb4929502795b40324bd5ffda2840ec37793acd
Cr-Commit-Position: refs/heads/master@{#34070}

Powered by Google App Engine
This is Rietveld 408576698